zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete obsolete RtcEventLogOutputFile constructor

Browse Source 
Followup to https://webrtc-review.googlesource.com/c/src/+/134460.

Bug: webrtc:6463
Change-Id: Ib6574b02b21fddc598c1f67c7e2b515f01d33204
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/139887
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28206}
This commit is contained in:
Niels Möller
2019-06-03 15:25:20 +02:00
committed by Commit Bot
parent 12561e06ce
commit dec9f74b8d
5 changed files with 18 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
pc/peer_connection_interface_unittest.cc
View File

@ -451,6 +451,12 @@ static const char kDtlsSdesFallbackSdp[] =
"inline:NzB4d1BINUAvLEw6UzF3WSJ+PSdFcGdUJShpX1Zj|2^20|1:32 "
"dummy_session_params\r\n";
class RtcEventLogOutputNull final : public RtcEventLogOutput {
public:
bool IsActive() const override { return true; }
bool Write(const std::string& output) override { return true; }
};
using ::cricket::StreamParams;
using ::testing::Exactly;
using ::testing::Values;
@ -3453,11 +3459,9 @@ TEST_P(PeerConnectionInterfaceTest,
// The RtcEventLog will be reset when the PeerConnection is closed.
pc_->Close();
rtc::PlatformFile file = 0;
int64_t max_size_bytes = 1024;
EXPECT_FALSE(pc_->StartRtcEventLog(
absl::make_unique<webrtc::RtcEventLogOutputFile>(file, max_size_bytes),
webrtc::RtcEventLog::kImmediateOutput));
EXPECT_FALSE(
pc_->StartRtcEventLog(absl::make_unique<webrtc::RtcEventLogOutputNull>(),
webrtc::RtcEventLog::kImmediateOutput));
pc_->StopRtcEventLog();
}