zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Suppressing TestUdpReadyToSendIPv4 on ASan.

Browse Source 
The test is flaky on Asan.

BUG=webrtc:4958

Review URL: https://codereview.webrtc.org/1388203004

Cr-Commit-Position: refs/heads/master@{#10313}
This commit is contained in:
minyue
2015-10-17 13:10:46 -07:00
committed by Commit bot
parent 743f50aac8
commit df200d1ef7
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
webrtc/base/physicalsocketserver_unittest.cc
View File

@ -214,14 +214,17 @@ TEST_F(PhysicalSocketTest, MAYBE_TestUdpIPv6) {
// Also disable for MSan, see:
// https://code.google.com/p/webrtc/issues/detail?id=4958
// TODO(deadbeef): Enable again once test is reimplemented to be unflaky.
#if !defined(THREAD_SANITIZER) && !defined(MEMORY_SANITIZER)
TEST_F(PhysicalSocketTest, TestUdpReadyToSendIPv4) {
// Also disable for ASan.
#if defined(THREAD_SANITIZER) || defined(MEMORY_SANITIZER) || \
defined(ADDRESS_SANITIZER)
#define MAYBE_TestUdpReadyToSendIPv4 DISABLED_TestUdpReadyToSendIPv4
#else
#define MAYBE_TestUdpReadyToSendIPv4 TestUdpReadyToSendIPv4
#endif
TEST_F(PhysicalSocketTest, MAYBE_TestUdpReadyToSendIPv4) {
SocketTest::TestUdpReadyToSendIPv4();
}
#endif // if !defined(THREAD_SANITIZER) && !defined(MEMORY_SANITIZER)
TEST_F(PhysicalSocketTest, TestUdpReadyToSendIPv6) {
SocketTest::TestUdpReadyToSendIPv6();
}