Move Offset constants from VideoSendTiming value to VideoTimingExtension class

These constants describes how value should be put on the wire and thus
belong to the extension builder/writer class rather than extension value class

Bug: None
Change-Id: I65ca3923eddcc2e48563ad69b98356c159ad86be
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166461
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30305}
This commit is contained in:
Danil Chapovalov
2020-01-17 15:37:31 +01:00
committed by Commit Bot
parent 274cc7fadf
commit df2c601616
5 changed files with 45 additions and 39 deletions

View File

@ -15,6 +15,7 @@
#include <utility>
#include "modules/rtp_rtcp/source/byte_io.h"
#include "modules/rtp_rtcp/source/rtp_header_extensions.h"
#include "rtc_base/checks.h"
#include "rtc_base/logging.h"
#include "rtc_base/numerics/safe_conversions.h"
@ -167,10 +168,12 @@ void RtpPacket::ZeroMutableExtensions() {
case RTPExtensionType::kRtpExtensionVideoTiming: {
// Nullify last entries, starting at pacer delay.
// These are set by pacer and SFUs
if (VideoSendTiming::kPacerExitDeltaOffset < extension.length) {
memset(WriteAt(extension.offset +
VideoSendTiming::kPacerExitDeltaOffset),
0, extension.length - VideoSendTiming::kPacerExitDeltaOffset);
if (VideoTimingExtension::kPacerExitDeltaOffset < extension.length) {
memset(
WriteAt(extension.offset +
VideoTimingExtension::kPacerExitDeltaOffset),
0,
extension.length - VideoTimingExtension::kPacerExitDeltaOffset);
}
break;
}