From e17d111f4a20de9e1b0ffc7d508968558c056eb5 Mon Sep 17 00:00:00 2001 From: Florent Castelli Date: Mon, 4 Apr 2022 14:52:21 +0200 Subject: [PATCH] dcsctp: Remove dependency on //rtc_base It's not used and pulls a lot of dependencies. Bug: None Change-Id: I8fd41b1f5793b281fddb83891d63b6e3eca5235f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257902 Auto-Submit: Florent Castelli Commit-Queue: Florent Castelli Reviewed-by: Mirko Bonadei Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/main@{#36426} --- BUILD.gn | 1 - net/dcsctp/fuzzers/BUILD.gn | 1 - net/dcsctp/packet/BUILD.gn | 9 --------- net/dcsctp/public/BUILD.gn | 1 - net/dcsctp/rx/BUILD.gn | 3 --- net/dcsctp/socket/BUILD.gn | 5 ----- net/dcsctp/testing/BUILD.gn | 1 - net/dcsctp/timer/BUILD.gn | 2 -- 8 files changed, 23 deletions(-) diff --git a/BUILD.gn b/BUILD.gn index 26301d6d48..23e7edec26 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -734,7 +734,6 @@ rtc_static_library("dcsctp") { "net/dcsctp/public:types", "net/dcsctp/socket:dcsctp_socket", "net/dcsctp/timer:task_queue_timeout", - "rtc_base", ] } diff --git a/net/dcsctp/fuzzers/BUILD.gn b/net/dcsctp/fuzzers/BUILD.gn index c00a02251c..13d9b75f56 100644 --- a/net/dcsctp/fuzzers/BUILD.gn +++ b/net/dcsctp/fuzzers/BUILD.gn @@ -13,7 +13,6 @@ rtc_library("dcsctp_fuzzers") { deps = [ "../../../api:array_view", "../../../api/task_queue:task_queue", - "../../../rtc_base", "../../../rtc_base:checks", "../../../rtc_base:rtc_base_approved", "../common:math", diff --git a/net/dcsctp/packet/BUILD.gn b/net/dcsctp/packet/BUILD.gn index 9c08ebc80e..7541633c47 100644 --- a/net/dcsctp/packet/BUILD.gn +++ b/net/dcsctp/packet/BUILD.gn @@ -15,7 +15,6 @@ group("packet") { rtc_source_set("bounded_io") { deps = [ "../../../api:array_view", - "../../../rtc_base", "../../../rtc_base:checks", "../../../rtc_base:rtc_base_approved", ] @@ -29,7 +28,6 @@ rtc_library("tlv_trait") { deps = [ ":bounded_io", "../../../api:array_view", - "../../../rtc_base", "../../../rtc_base:checks", "../../../rtc_base:rtc_base_approved", ] @@ -45,7 +43,6 @@ rtc_library("tlv_trait") { rtc_source_set("data") { deps = [ - "../../../rtc_base", "../../../rtc_base:checks", "../../../rtc_base:rtc_base_approved", "../common:internal_types", @@ -57,7 +54,6 @@ rtc_source_set("data") { rtc_library("crc32c") { deps = [ "../../../api:array_view", - "../../../rtc_base", "../../../rtc_base:checks", "../../../rtc_base:rtc_base_approved", "//third_party/crc32c", @@ -74,7 +70,6 @@ rtc_library("parameter") { ":data", ":tlv_trait", "../../../api:array_view", - "../../../rtc_base", "../../../rtc_base:checks", "../../../rtc_base:rtc_base_approved", "../common:internal_types", @@ -119,7 +114,6 @@ rtc_library("error_cause") { ":parameter", ":tlv_trait", "../../../api:array_view", - "../../../rtc_base", "../../../rtc_base:checks", "../../../rtc_base:rtc_base_approved", "../common:internal_types", @@ -172,7 +166,6 @@ rtc_library("chunk") { ":parameter", ":tlv_trait", "../../../api:array_view", - "../../../rtc_base", "../../../rtc_base:checks", "../../../rtc_base:rtc_base_approved", "../common:math", @@ -229,7 +222,6 @@ rtc_library("chunk") { rtc_library("chunk_validators") { deps = [ ":chunk", - "../../../rtc_base", "../../../rtc_base:checks", "../../../rtc_base:rtc_base_approved", ] @@ -245,7 +237,6 @@ rtc_library("sctp_packet") { ":chunk", ":crc32c", "../../../api:array_view", - "../../../rtc_base", "../../../rtc_base:checks", "../../../rtc_base:rtc_base_approved", "../common:internal_types", diff --git a/net/dcsctp/public/BUILD.gn b/net/dcsctp/public/BUILD.gn index 4fad23e9b8..eb0eb04dfc 100644 --- a/net/dcsctp/public/BUILD.gn +++ b/net/dcsctp/public/BUILD.gn @@ -26,7 +26,6 @@ rtc_source_set("socket") { ":types", "../../../api:array_view", "../../../api/task_queue:task_queue", - "../../../rtc_base", "../../../rtc_base:checks", "../../../rtc_base:rtc_base_approved", ] diff --git a/net/dcsctp/rx/BUILD.gn b/net/dcsctp/rx/BUILD.gn index de96678a3e..ef13676c55 100644 --- a/net/dcsctp/rx/BUILD.gn +++ b/net/dcsctp/rx/BUILD.gn @@ -11,7 +11,6 @@ import("../../../webrtc.gni") rtc_library("data_tracker") { deps = [ "../../../api:array_view", - "../../../rtc_base", "../../../rtc_base:checks", "../../../rtc_base:rtc_base_approved", "../common:sequence_numbers", @@ -48,7 +47,6 @@ rtc_library("traditional_reassembly_streams") { deps = [ ":reassembly_streams", "../../../api:array_view", - "../../../rtc_base", "../../../rtc_base:checks", "../../../rtc_base:rtc_base_approved", "../common:sequence_numbers", @@ -72,7 +70,6 @@ rtc_library("reassembly_queue") { ":reassembly_streams", ":traditional_reassembly_streams", "../../../api:array_view", - "../../../rtc_base", "../../../rtc_base:checks", "../../../rtc_base:rtc_base_approved", "../common:internal_types", diff --git a/net/dcsctp/socket/BUILD.gn b/net/dcsctp/socket/BUILD.gn index 083adaa9dd..c6915f0879 100644 --- a/net/dcsctp/socket/BUILD.gn +++ b/net/dcsctp/socket/BUILD.gn @@ -23,7 +23,6 @@ rtc_library("heartbeat_handler") { deps = [ ":context", "../../../api:array_view", - "../../../rtc_base", "../../../rtc_base:checks", "../../../rtc_base:rtc_base_approved", "../packet:bounded_io", @@ -49,7 +48,6 @@ rtc_library("stream_reset_handler") { deps = [ ":context", "../../../api:array_view", - "../../../rtc_base", "../../../rtc_base:checks", "../../../rtc_base:rtc_base_approved", "../../../rtc_base/containers:flat_set", @@ -99,7 +97,6 @@ rtc_library("transmission_control_block") { ":stream_reset_handler", "../../../api:array_view", "../../../api/task_queue:task_queue", - "../../../rtc_base", "../../../rtc_base:checks", "../../../rtc_base:rtc_base_approved", "../common:sequence_numbers", @@ -138,7 +135,6 @@ rtc_library("dcsctp_socket") { "../../../api:refcountedbase", "../../../api:scoped_refptr", "../../../api/task_queue:task_queue", - "../../../rtc_base", "../../../rtc_base:checks", "../../../rtc_base:rtc_base_approved", "../common:internal_types", @@ -232,7 +228,6 @@ if (rtc_include_tests) { "../../../call:simulated_network", "../../../rtc_base:checks", "../../../rtc_base:gunit_helpers", - "../../../rtc_base:rtc_base", "../../../rtc_base:rtc_base_approved", "../../../rtc_base:rtc_base_tests_utils", "../../../rtc_base:socket_address", diff --git a/net/dcsctp/testing/BUILD.gn b/net/dcsctp/testing/BUILD.gn index 5367ef8c6f..b426505cb3 100644 --- a/net/dcsctp/testing/BUILD.gn +++ b/net/dcsctp/testing/BUILD.gn @@ -17,7 +17,6 @@ rtc_library("data_generator") { testonly = true deps = [ "../../../api:array_view", - "../../../rtc_base", "../../../rtc_base:checks", "../../../rtc_base:rtc_base_approved", "../common:internal_types", diff --git a/net/dcsctp/timer/BUILD.gn b/net/dcsctp/timer/BUILD.gn index 4470903ffc..8579b744f8 100644 --- a/net/dcsctp/timer/BUILD.gn +++ b/net/dcsctp/timer/BUILD.gn @@ -12,7 +12,6 @@ rtc_library("timer") { deps = [ "../../../api:array_view", "../../../api/task_queue:task_queue", - "../../../rtc_base", "../../../rtc_base:checks", "../../../rtc_base:rtc_base_approved", "../../../rtc_base/containers:flat_map", @@ -35,7 +34,6 @@ rtc_library("task_queue_timeout") { deps = [ "../../../api:array_view", "../../../api/task_queue:task_queue", - "../../../rtc_base", "../../../rtc_base:checks", "../../../rtc_base:rtc_base_approved", "../../../rtc_base/task_utils:pending_task_safety_flag",