zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove the HighPassFilter interface

Browse Source 
The functionality remains unaffected.
Filter toggling is still available via webrtc::AudioProcessing::Config.
Example:
webrtc::AudioProcessing::Config config = apm.GetConfig();
// Read settings
if (config.high_pass_filter.enabled) { ... }
// Apply setting
config.high_pass_filter.enabled = true;
apm.ApplyConfig();

Bug: webrtc:9535
Change-Id: Ib4c4b04078bbb490ebdab9721b8c7811d73777a8
Reviewed-on: https://webrtc-review.googlesource.com/c/102541
Commit-Queue: Sam Zackrisson <saza@webrtc.org>
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25198}
This commit is contained in:
Sam Zackrisson
2018-10-16 10:48:40 +02:00
committed by Commit Bot
parent d419db9a9e
commit e2405c1a82
6 changed files with 0 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
modules/audio_processing/audio_processing_impl.cc
View File

@ -115,29 +115,6 @@ static const size_t kMaxAllowedValuesOfSamplesPerFrame = 480;
// TODO(peah): Decrease this once we properly handle hugely unbalanced
// reverse and forward call numbers.
static const size_t kMaxNumFramesToBuffer = 100;
class HighPassFilterImpl : public HighPassFilter {
public:
explicit HighPassFilterImpl(AudioProcessingImpl* apm) : apm_(apm) {}
~HighPassFilterImpl() override = default;
// HighPassFilter implementation.
int Enable(bool enable) override {
apm_->MutateConfig([enable](AudioProcessing::Config* config) {
config->high_pass_filter.enabled = enable;
});
return AudioProcessing::kNoError;
}
bool is_enabled() const override {
return apm_->GetConfig().high_pass_filter.enabled;
}
private:
AudioProcessingImpl* apm_;
RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(HighPassFilterImpl);
};
} // namespace
// Throughout webrtc, it's assumed that success is represented by zero.
@ -352,7 +329,6 @@ AudioProcessingImpl::AudioProcessingImpl(
render_runtime_settings_(kRuntimeSettingQueueSize),
capture_runtime_settings_enqueuer_(&capture_runtime_settings_),
render_runtime_settings_enqueuer_(&render_runtime_settings_),
high_pass_filter_impl_(new HighPassFilterImpl(this)),
echo_control_factory_(std::move(echo_control_factory)),
submodule_states_(!!capture_post_processor,
!!render_pre_processor,
@ -1727,10 +1703,6 @@ GainControl* AudioProcessingImpl::gain_control() const {
return public_submodules_->gain_control.get();
}
HighPassFilter* AudioProcessingImpl::high_pass_filter() const {
return high_pass_filter_impl_.get();
}
LevelEstimator* AudioProcessingImpl::level_estimator() const {
return public_submodules_->level_estimator.get();
}