Declare api:libjingle_peerconnection_api dependency on media:media_base

Deletes one of the two // nogncheck comments in peerconnection_interface.h.

Bug: webrtc:8733
Change-Id: I7cda4957206c4c5f36261517718b526734bad68a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150798
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Benjamin Wright <benwright@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29247}

api/BUILD.gn

@@ -205,6 +205,7 @@ rtc_static_library("libjingle_peerconnection_api") {
     # targets like pnacl. API should not depend on anything outside of this
     # file, really. All these should arguably go away in time.
     "..:webrtc_common",
+    "../media:rtc_media_base",
     "../media:rtc_media_config",
     "../modules/audio_processing:audio_processing_statistics",
     "../rtc_base",

api/peer_connection_interface.h

@@ -103,10 +103,10 @@
 #include "api/transport/network_control.h"
 #include "api/turn_customizer.h"
 #include "media/base/media_config.h"
+#include "media/base/media_engine.h"
 // TODO(bugs.webrtc.org/7447): We plan to provide a way to let applications
 // inject a PacketSocketFactory and/or NetworkManager, and not expose
 // PortAllocator in the PeerConnection api.
-#include "media/base/media_engine.h"  // nogncheck
 #include "p2p/base/port_allocator.h"  // nogncheck
 #include "rtc_base/network.h"
 #include "rtc_base/rtc_certificate.h"

modules/rtp_rtcp/BUILD.gn

@@ -102,7 +102,6 @@ rtc_source_set("rtp_rtcp_format") {
     "..:module_api_public",
     "../../api:array_view",
     "../../api:function_view",
-    "../../api:libjingle_peerconnection_api",
     "../../api:rtp_headers",
     "../../api:rtp_parameters",
     "../../api/audio_codecs:audio_codecs_api",