zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Move some numeric utility code from rtc_base/ to rtc_base/numerics/

Browse Source 
Specifically, I'm moving

  safe_compare.h
  safe_conversions.h
  safe_minmax.h

They shouldn't be part of the API, and moving them to an appropriate
subdirectory of rtc_base/ is a good way to keep track of that.

BUG=webrtc:8445

Change-Id: I458531aeb30bcf4291c4bec3bf22a2fffbf054ff
Reviewed-on: https://webrtc-review.googlesource.com/20860
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20829}
This commit is contained in:
Karl Wiberg
2017-11-22 10:42:26 +01:00
committed by Commit Bot
parent 9deda4828d
commit e40468ba3d
114 changed files with 138 additions and 137 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/audio_coding/acm2/acm_receiver.cc
View File

@ -25,7 +25,7 @@
#include "rtc_base/checks.h"
#include "rtc_base/format_macros.h"
#include "rtc_base/logging.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "system_wrappers/include/clock.h"
namespace webrtc {

2
modules/audio_coding/acm2/acm_receiver_unittest.cc
View File

@ -18,7 +18,7 @@
#include "modules/audio_coding/include/audio_coding_module.h"
#include "modules/audio_coding/neteq/tools/rtp_generator.h"
#include "rtc_base/checks.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "system_wrappers/include/clock.h"
#include "test/gtest.h"
#include "test/testsupport/fileutils.h"

2
modules/audio_coding/acm2/audio_coding_module.cc
View File

@ -19,7 +19,7 @@
#include "modules/audio_coding/acm2/rent_a_codec.h"
#include "rtc_base/checks.h"
#include "rtc_base/logging.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "system_wrappers/include/metrics.h"
namespace webrtc {

2
modules/audio_coding/acm2/audio_coding_module_unittest.cc
View File

@ -35,9 +35,9 @@
#include "modules/include/module_common_types.h"
#include "rtc_base/criticalsection.h"
#include "rtc_base/md5digest.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "rtc_base/platform_thread.h"
#include "rtc_base/refcountedobject.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/thread_annotations.h"
#include "system_wrappers/include/clock.h"
#include "system_wrappers/include/event_wrapper.h"

2
modules/audio_coding/audio_network_adaptor/bitrate_controller_unittest.cc
View File

@ -9,7 +9,7 @@
*/
#include "modules/audio_coding/audio_network_adaptor/bitrate_controller.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "test/field_trial.h"
#include "test/gtest.h"

2
modules/audio_coding/codecs/audio_format_conversion.cc
View File

@ -15,7 +15,7 @@
#include "api/array_view.h"
#include "api/optional.h"
#include "rtc_base/checks.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "rtc_base/sanitizer.h"
namespace webrtc {

2
modules/audio_coding/codecs/builtin_audio_encoder_factory_unittest.cc
View File

@ -13,7 +13,7 @@
#include <vector>
#include "api/audio_codecs/builtin_audio_encoder_factory.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "test/gmock.h"
#include "test/gtest.h"

2
modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc
View File

@ -14,7 +14,7 @@
#include "common_audio/vad/mock/mock_vad.h"
#include "modules/audio_coding/codecs/cng/audio_encoder_cng.h"
#include "rtc_base/constructormagic.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "test/gtest.h"
#include "test/mock_audio_encoder.h"

2
modules/audio_coding/codecs/cng/webrtc_cng.cc
View File

@ -13,7 +13,7 @@
#include <algorithm>
#include "common_audio/signal_processing/include/signal_processing_library.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
namespace webrtc {

2
modules/audio_coding/codecs/g722/audio_encoder_g722.cc
View File

@ -16,7 +16,7 @@
#include "common_types.h" // NOLINT(build/include)
#include "modules/audio_coding/codecs/g722/g722_interface.h"
#include "rtc_base/checks.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
namespace webrtc {

2
modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.cc
View File

@ -15,7 +15,7 @@
#include "common_types.h" // NOLINT(build/include)
#include "modules/audio_coding/codecs/ilbc/ilbc.h"
#include "rtc_base/checks.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
namespace webrtc {

2
modules/audio_coding/codecs/isac/unittest.cc
View File

@ -17,7 +17,7 @@
#include "modules/audio_coding/codecs/isac/main/include/audio_encoder_isac.h"
#include "modules/audio_coding/neteq/tools/input_audio_file.h"
#include "rtc_base/buffer.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "test/gtest.h"
#include "test/testsupport/fileutils.h"

5
modules/audio_coding/codecs/legacy_encoded_audio_frame_unittest.cc
View File

@ -8,9 +8,10 @@
* be found in the AUTHORS file in the root of the source tree.
*/
#include "modules/audio_coding/acm2/rent_a_codec.h"
#include "modules/audio_coding/codecs/legacy_encoded_audio_frame.h"
#include "rtc_base/safe_conversions.h"
#include "modules/audio_coding/acm2/rent_a_codec.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "test/gtest.h"
namespace webrtc {

4
modules/audio_coding/codecs/opus/audio_encoder_opus.cc
View File

@ -22,10 +22,10 @@
#include "rtc_base/checks.h"
#include "rtc_base/logging.h"
#include "rtc_base/numerics/exp_filter.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "rtc_base/numerics/safe_minmax.h"
#include "rtc_base/protobuf_utils.h"
#include "rtc_base/ptr_util.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/safe_minmax.h"
#include "rtc_base/string_to_number.h"
#include "rtc_base/timeutils.h"
#include "system_wrappers/include/field_trial.h"

2
modules/audio_coding/codecs/opus/opus_unittest.cc
View File

@ -15,7 +15,7 @@
#include "modules/audio_coding/codecs/opus/opus_interface.h"
#include "modules/audio_coding/neteq/tools/audio_loop.h"
#include "rtc_base/checks.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "test/gtest.h"
#include "test/testsupport/fileutils.h"

2
modules/audio_coding/codecs/pcm16b/audio_encoder_pcm16b.cc
View File

@ -15,7 +15,7 @@
#include "common_types.h" // NOLINT(build/include)
#include "modules/audio_coding/codecs/pcm16b/pcm16b.h"
#include "rtc_base/checks.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
namespace webrtc {

2
modules/audio_coding/codecs/red/audio_encoder_copy_red_unittest.cc
View File

@ -13,7 +13,7 @@
#include "modules/audio_coding/codecs/red/audio_encoder_copy_red.h"
#include "rtc_base/checks.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "test/gtest.h"
#include "test/mock_audio_encoder.h"

2
modules/audio_coding/neteq/audio_multi_vector_unittest.cc
View File

@ -9,13 +9,13 @@
*/
#include "modules/audio_coding/neteq/audio_multi_vector.h"
#include "rtc_base/safe_conversions.h"
#include <assert.h>
#include <stdlib.h>
#include <string>
#include "rtc_base/numerics/safe_conversions.h"
#include "test/gtest.h"
#include "typedefs.h" // NOLINT(build/include)

2
modules/audio_coding/neteq/audio_vector_unittest.cc
View File

@ -9,13 +9,13 @@
*/
#include "modules/audio_coding/neteq/audio_vector.h"
#include "rtc_base/safe_conversions.h"
#include <assert.h>
#include <stdlib.h>
#include <string>
#include "rtc_base/numerics/safe_conversions.h"
#include "test/gtest.h"
#include "typedefs.h" // NOLINT(build/include)

2
modules/audio_coding/neteq/delay_manager.cc
View File

@ -20,7 +20,7 @@
#include "modules/audio_coding/neteq/delay_peak_detector.h"
#include "modules/include/module_common_types.h"
#include "rtc_base/logging.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "system_wrappers/include/field_trial.h"
namespace webrtc {

2
modules/audio_coding/neteq/delay_peak_detector.cc
View File

@ -13,7 +13,7 @@
#include <algorithm> // max
#include "rtc_base/checks.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "system_wrappers/include/field_trial.h"
namespace webrtc {

2
modules/audio_coding/neteq/expand.cc
View File

@ -23,7 +23,7 @@
#include "modules/audio_coding/neteq/random_vector.h"
#include "modules/audio_coding/neteq/statistics_calculator.h"
#include "modules/audio_coding/neteq/sync_buffer.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
namespace webrtc {

2
modules/audio_coding/neteq/expand_unittest.cc
View File

@ -18,7 +18,7 @@
#include "modules/audio_coding/neteq/statistics_calculator.h"
#include "modules/audio_coding/neteq/sync_buffer.h"
#include "modules/audio_coding/neteq/tools/resample_input_audio_file.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "test/gtest.h"
#include "test/testsupport/fileutils.h"

4
modules/audio_coding/neteq/merge.cc
View File

@ -22,8 +22,8 @@
#include "modules/audio_coding/neteq/dsp_helper.h"
#include "modules/audio_coding/neteq/expand.h"
#include "modules/audio_coding/neteq/sync_buffer.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/safe_minmax.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "rtc_base/numerics/safe_minmax.h"
namespace webrtc {

2
modules/audio_coding/neteq/neteq_impl.cc
View File

@ -44,7 +44,7 @@
#include "modules/include/module_common_types.h"
#include "rtc_base/checks.h"
#include "rtc_base/logging.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "rtc_base/sanitizer.h"
#include "rtc_base/trace_event.h"
#include "system_wrappers/include/field_trial.h"

2
modules/audio_coding/neteq/neteq_impl_unittest.cc
View File

@ -28,7 +28,7 @@
#include "modules/audio_coding/neteq/sync_buffer.h"
#include "modules/audio_coding/neteq/timestamp_scaler.h"
#include "modules/include/module_common_types.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "test/gmock.h"
#include "test/gtest.h"
#include "test/mock_audio_decoder.h"

2
modules/audio_coding/neteq/neteq_unittest.cc
View File

@ -28,8 +28,8 @@
#include "modules/include/module_common_types.h"
#include "rtc_base/flags.h"
#include "rtc_base/ignore_wundef.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "rtc_base/protobuf_utils.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/sha1digest.h"
#include "rtc_base/stringencode.h"
#include "test/gtest.h"

2
modules/audio_coding/neteq/normal.h
View File

@ -19,7 +19,7 @@
#include "modules/audio_coding/neteq/defines.h"
#include "rtc_base/checks.h"
#include "rtc_base/constructormagic.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "typedefs.h" // NOLINT(build/include)
namespace webrtc {

2
modules/audio_coding/neteq/red_payload_splitter.cc
View File

@ -16,7 +16,7 @@
#include "modules/audio_coding/neteq/decoder_database.h"
#include "rtc_base/checks.h"
#include "rtc_base/logging.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
namespace webrtc {

2
modules/audio_coding/neteq/red_payload_splitter_unittest.cc
View File

@ -20,7 +20,7 @@
#include "api/audio_codecs/builtin_audio_decoder_factory.h"
#include "modules/audio_coding/neteq/mock/mock_decoder_database.h"
#include "modules/audio_coding/neteq/packet.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "test/gtest.h"
#include "test/mock_audio_decoder_factory.h"

2
modules/audio_coding/neteq/statistics_calculator.cc
View File

@ -16,7 +16,7 @@
#include "modules/audio_coding/neteq/delay_manager.h"
#include "rtc_base/checks.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "system_wrappers/include/metrics.h"
namespace webrtc {

2
modules/audio_coding/neteq/sync_buffer_unittest.cc
View File

@ -9,7 +9,7 @@
*/
#include "modules/audio_coding/neteq/sync_buffer.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "test/gtest.h"

2
modules/audio_coding/neteq/test/neteq_ilbc_quality_test.cc
View File

@ -14,7 +14,7 @@
#include "modules/audio_coding/neteq/tools/neteq_quality_test.h"
#include "rtc_base/checks.h"
#include "rtc_base/flags.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "test/testsupport/fileutils.h"
using testing::InitGoogleTest;

2
modules/audio_coding/neteq/test/neteq_pcmu_quality_test.cc
View File

@ -14,7 +14,7 @@
#include "modules/audio_coding/neteq/tools/neteq_quality_test.h"
#include "rtc_base/checks.h"
#include "rtc_base/flags.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "test/testsupport/fileutils.h"
using testing::InitGoogleTest;

2
modules/audio_coding/neteq/time_stretch.cc
View File

@ -17,7 +17,7 @@
#include "modules/audio_coding/neteq/background_noise.h"
#include "modules/audio_coding/neteq/cross_correlation.h"
#include "modules/audio_coding/neteq/dsp_helper.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
namespace webrtc {

2
modules/audio_coding/neteq/tools/encode_neteq_input.cc
View File

@ -13,7 +13,7 @@
#include <utility>
#include "rtc_base/checks.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
namespace webrtc {
namespace test {

2
modules/audio_coding/neteq/tools/fake_decode_from_file.cc
View File

@ -12,7 +12,7 @@
#include "modules/rtp_rtcp/source/byte_io.h"
#include "rtc_base/checks.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
namespace webrtc {
namespace test {

2
modules/audio_coding/neteq/tools/input_audio_file_unittest.cc
View File

@ -11,7 +11,7 @@
// Unit tests for test InputAudioFile class.
#include "modules/audio_coding/neteq/tools/input_audio_file.h"
#include "rtc_base/safe_conversions.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "test/gtest.h"