diff --git a/webrtc/BUILD.gn b/webrtc/BUILD.gn index 860f93a89b..9f1fd0b172 100644 --- a/webrtc/BUILD.gn +++ b/webrtc/BUILD.gn @@ -302,9 +302,8 @@ rtc_static_library("webrtc_common") { "voice_engine_configurations.h", ] - if (is_clang && !is_nacl) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } @@ -483,9 +482,8 @@ if (rtc_include_tests) { configs += [ ":rtc_unittests_config" ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -535,9 +533,8 @@ if (rtc_include_tests) { rtc_test("xmllite_xmpp_unittests") { configs += [ ":rtc_unittests_config" ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -600,9 +597,8 @@ if (rtc_include_tests) { "video:video_tests", ] data = video_engine_tests_resources - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } if (is_android) { @@ -629,9 +625,8 @@ if (rtc_include_tests) { if (!is_android) { deps += [ "modules/video_capture:video_capture_internal_impl" ] } - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } @@ -692,9 +687,8 @@ if (rtc_include_tests) { "//testing/gtest", "//third_party/gflags", ] - if (is_clang && !is_nacl) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } @@ -743,9 +737,8 @@ if (rtc_include_tests) { if (is_ios) { deps += [ ":webrtc_perf_tests_bundle_data" ] } - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } @@ -774,9 +767,8 @@ if (rtc_include_tests) { shard_timeout = 900 } - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } diff --git a/webrtc/api/BUILD.gn b/webrtc/api/BUILD.gn index bd701790b2..e2df526286 100644 --- a/webrtc/api/BUILD.gn +++ b/webrtc/api/BUILD.gn @@ -117,7 +117,7 @@ rtc_static_library("libjingle_peerconnection") { configs += [ ":libjingle_peerconnection_warnings_config" ] - if (is_clang) { + if (!build_with_chromium && is_clang) { # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -186,7 +186,7 @@ if (is_android && !build_with_chromium) { configs += [ ":libjingle_peerconnection_jni_warnings_config" ] - if (is_clang) { + if (!build_with_chromium && is_clang) { # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:extra_warnings", @@ -382,7 +382,7 @@ if (rtc_include_tests) { configs += [ ":peerconnection_unittests_config" ] - if (is_clang) { + if (!build_with_chromium && is_clang) { # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } diff --git a/webrtc/audio/BUILD.gn b/webrtc/audio/BUILD.gn index 14607cdd73..5cba616c53 100644 --- a/webrtc/audio/BUILD.gn +++ b/webrtc/audio/BUILD.gn @@ -20,9 +20,8 @@ rtc_static_library("audio") { "scoped_voe_interface.h", ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -46,9 +45,8 @@ if (rtc_include_tests) { "//testing/gmock", "//testing/gtest", ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } diff --git a/webrtc/base/BUILD.gn b/webrtc/base/BUILD.gn index ea97be08e7..402691fbe0 100644 --- a/webrtc/base/BUILD.gn +++ b/webrtc/base/BUILD.gn @@ -786,7 +786,7 @@ if (rtc_include_tests) { "//testing/gtest", ] - if (is_clang) { + if (!build_with_chromium && is_clang) { # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } diff --git a/webrtc/call/BUILD.gn b/webrtc/call/BUILD.gn index bd2b30e570..97643d1238 100644 --- a/webrtc/call/BUILD.gn +++ b/webrtc/call/BUILD.gn @@ -16,9 +16,8 @@ rtc_static_library("call") { "transport_adapter.h", ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -49,9 +48,8 @@ if (rtc_include_tests) { "//testing/gmock", "//testing/gtest", ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } diff --git a/webrtc/common_audio/BUILD.gn b/webrtc/common_audio/BUILD.gn index 6258fb4552..bfed73eeeb 100644 --- a/webrtc/common_audio/BUILD.gn +++ b/webrtc/common_audio/BUILD.gn @@ -174,9 +174,8 @@ rtc_static_library("common_audio") { public_configs = [ ":common_audio_config" ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -196,9 +195,8 @@ if (current_cpu == "x86" || current_cpu == "x64") { cflags = [ "-msse2" ] } - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } @@ -231,9 +229,8 @@ if (rtc_build_with_neon) { ] } - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } @@ -281,9 +278,8 @@ if (rtc_include_tests) { defines = [ "RTC_USE_OPENMAX_DL" ] } - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } diff --git a/webrtc/common_video/BUILD.gn b/webrtc/common_video/BUILD.gn index 845a5eb8af..5fbe1e875c 100644 --- a/webrtc/common_video/BUILD.gn +++ b/webrtc/common_video/BUILD.gn @@ -45,9 +45,8 @@ rtc_static_library("common_video") { public_configs = [ ":common_video_config" ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -105,9 +104,8 @@ if (rtc_include_tests) { # TODO(jschuh): Bug 1348: fix this warning. configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } diff --git a/webrtc/examples/BUILD.gn b/webrtc/examples/BUILD.gn index bc2d84563a..b0b530fdd0 100644 --- a/webrtc/examples/BUILD.gn +++ b/webrtc/examples/BUILD.gn @@ -413,9 +413,8 @@ if (is_linux || is_win) { "peerconnection/client/peer_connection_client.h", ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } if (is_win) { @@ -469,9 +468,8 @@ if (is_linux || is_win) { "//webrtc/base:rtc_base_approved", "//webrtc/tools:command_line_parser", ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } @@ -485,9 +483,8 @@ if (is_linux || is_win) { "//webrtc/system_wrappers:field_trial_default", "//webrtc/system_wrappers:metrics_default", ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } @@ -501,9 +498,8 @@ if (is_linux || is_win) { "//webrtc/system_wrappers:field_trial_default", "//webrtc/system_wrappers:metrics_default", ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } @@ -517,9 +513,8 @@ if (is_linux || is_win) { "//webrtc/system_wrappers:field_trial_default", "//webrtc/system_wrappers:metrics_default", ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } diff --git a/webrtc/libjingle/xmpp/BUILD.gn b/webrtc/libjingle/xmpp/BUILD.gn index 879d67236a..17a52fbaad 100644 --- a/webrtc/libjingle/xmpp/BUILD.gn +++ b/webrtc/libjingle/xmpp/BUILD.gn @@ -139,9 +139,8 @@ rtc_static_library("rtc_xmpp") { "FEATURE_ENABLE_PSTN", ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } diff --git a/webrtc/logging/BUILD.gn b/webrtc/logging/BUILD.gn index 7078963d1e..fa28065373 100644 --- a/webrtc/logging/BUILD.gn +++ b/webrtc/logging/BUILD.gn @@ -39,9 +39,8 @@ rtc_static_library("rtc_event_log_impl") { defines += [ "ENABLE_RTC_EVENT_LOG" ] deps += [ ":rtc_event_log_proto" ] } - if (is_clang && !is_nacl) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } @@ -62,9 +61,8 @@ if (rtc_include_tests) { "//testing/gmock", "//testing/gtest", ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } @@ -91,9 +89,8 @@ if (rtc_enable_protobuf) { "..:webrtc_common", ] - if (is_clang && !is_nacl) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } diff --git a/webrtc/media/BUILD.gn b/webrtc/media/BUILD.gn index 122c404455..b61de328c3 100644 --- a/webrtc/media/BUILD.gn +++ b/webrtc/media/BUILD.gn @@ -113,7 +113,7 @@ rtc_static_library("rtc_media") { configs += [ ":rtc_media_warnings_config" ] - if (is_clang) { + if (!build_with_chromium && is_clang) { # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -236,9 +236,8 @@ if (rtc_include_tests) { include_dirs += [ "$rtc_libyuv_dir/include" ] } - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -331,10 +330,11 @@ if (rtc_include_tests) { ] } - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). + if (!build_with_chromium && is_clang) { suppressed_configs += [ "//build/config/clang:extra_warnings", + + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). "//build/config/clang:find_bad_constructs", ] } diff --git a/webrtc/modules/BUILD.gn b/webrtc/modules/BUILD.gn index ff0918e6d4..17da35dff4 100644 --- a/webrtc/modules/BUILD.gn +++ b/webrtc/modules/BUILD.gn @@ -106,7 +106,7 @@ if (rtc_include_tests) { deps += [ ":modules_tests_bundle_data" ] } - if (is_clang) { + if (!build_with_chromium && is_clang) { # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -258,7 +258,7 @@ if (rtc_include_tests) { deps += [ "audio_coding:ana_config_proto" ] defines = [ "WEBRTC_AUDIO_NETWORK_ADAPTOR_DEBUG_DUMP" ] } - if (is_clang) { + if (!build_with_chromium && is_clang) { # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -607,7 +607,7 @@ if (rtc_include_tests) { # TODO(jschuh): bugs.webrtc.org/1348: fix this warning. configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] - if (is_clang) { + if (!build_with_chromium && is_clang) { # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -715,7 +715,7 @@ if (rtc_include_tests) { "remote_bitrate_estimator/bwe_simulations.cc", ] - if (is_clang) { + if (!build_with_chromium && is_clang) { # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } diff --git a/webrtc/modules/audio_coding/BUILD.gn b/webrtc/modules/audio_coding/BUILD.gn index 80c1be81fd..078fb4bccc 100644 --- a/webrtc/modules/audio_coding/BUILD.gn +++ b/webrtc/modules/audio_coding/BUILD.gn @@ -884,8 +884,8 @@ rtc_source_set("neteq_test_minimal") { "neteq/tools/neteq_test.h", ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugins (bugs.webrtc.org/163). + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } @@ -952,9 +952,8 @@ if (rtc_include_tests) { "test/insert_packet_with_timing.cc", ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -989,8 +988,8 @@ if (rtc_include_tests) { "neteq/audio_decoder_unittest.cc", ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugins (bugs.webrtc.org/163). + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -1036,9 +1035,8 @@ if (rtc_include_tests) { "neteq/tools/rtc_event_log_source.h", ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugins - # (bugs.webrtc.org/163). + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -1058,9 +1056,8 @@ if (rtc_include_tests) { "neteq/tools/neteq_rtpplay.cc", ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugins - # (bugs.webrtc.org/163). + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -1092,9 +1089,8 @@ if (rtc_include_tests) { "codecs/tools/audio_codec_speed_test.h", ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugins - # (bugs.webrtc.org/163). + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -1122,8 +1118,8 @@ if (rtc_include_tests) { "neteq/tools/neteq_performance_test.h", ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugins (bugs.webrtc.org/163). + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -1142,8 +1138,8 @@ if (rtc_include_tests) { "neteq/tools/neteq_quality_test.h", ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugins (bugs.webrtc.org/163). + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -1194,8 +1190,8 @@ if (rtc_include_tests) { public_configs = [ ":neteq_unittest_tools_config" ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugins (bugs.webrtc.org/163). + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -1367,9 +1363,8 @@ if (rtc_include_tests) { "//third_party/gflags:gflags", ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } @@ -1618,9 +1613,8 @@ if (rtc_include_tests) { "//testing/gtest", ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } diff --git a/webrtc/modules/audio_conference_mixer/BUILD.gn b/webrtc/modules/audio_conference_mixer/BUILD.gn index 129ff5b5ec..58228b5a83 100644 --- a/webrtc/modules/audio_conference_mixer/BUILD.gn +++ b/webrtc/modules/audio_conference_mixer/BUILD.gn @@ -33,9 +33,8 @@ rtc_static_library("audio_conference_mixer") { public_configs = [ ":audio_conference_mixer_config" ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } diff --git a/webrtc/modules/audio_device/BUILD.gn b/webrtc/modules/audio_device/BUILD.gn index 31a02d1053..a0f6746c53 100644 --- a/webrtc/modules/audio_device/BUILD.gn +++ b/webrtc/modules/audio_device/BUILD.gn @@ -235,9 +235,8 @@ rtc_static_library("audio_device") { ] } - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } diff --git a/webrtc/modules/bitrate_controller/BUILD.gn b/webrtc/modules/bitrate_controller/BUILD.gn index 7bf28e4d73..28b3801010 100644 --- a/webrtc/modules/bitrate_controller/BUILD.gn +++ b/webrtc/modules/bitrate_controller/BUILD.gn @@ -26,9 +26,8 @@ rtc_static_library("bitrate_controller") { # TODO(jschuh): Bug 1348: fix this warning. configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } diff --git a/webrtc/modules/congestion_controller/BUILD.gn b/webrtc/modules/congestion_controller/BUILD.gn index 1069d624ff..84c344b7f2 100644 --- a/webrtc/modules/congestion_controller/BUILD.gn +++ b/webrtc/modules/congestion_controller/BUILD.gn @@ -25,9 +25,8 @@ rtc_static_library("congestion_controller") { # TODO(jschuh): Bug 1348: fix this warning. configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } diff --git a/webrtc/modules/desktop_capture/BUILD.gn b/webrtc/modules/desktop_capture/BUILD.gn index e7630565da..85d66f8be1 100644 --- a/webrtc/modules/desktop_capture/BUILD.gn +++ b/webrtc/modules/desktop_capture/BUILD.gn @@ -146,9 +146,8 @@ rtc_static_library("desktop_capture") { ] } - if (is_clang && !is_nacl) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } diff --git a/webrtc/modules/media_file/BUILD.gn b/webrtc/modules/media_file/BUILD.gn index f73c44bcac..37e966ddc2 100644 --- a/webrtc/modules/media_file/BUILD.gn +++ b/webrtc/modules/media_file/BUILD.gn @@ -27,9 +27,8 @@ rtc_static_library("media_file") { # TODO(jschuh): Bug 1348: fix this warning. configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } diff --git a/webrtc/modules/pacing/BUILD.gn b/webrtc/modules/pacing/BUILD.gn index 03c33d5ea7..cba0d3edc9 100644 --- a/webrtc/modules/pacing/BUILD.gn +++ b/webrtc/modules/pacing/BUILD.gn @@ -20,9 +20,8 @@ rtc_static_library("pacing") { "packet_router.h", ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } diff --git a/webrtc/modules/remote_bitrate_estimator/BUILD.gn b/webrtc/modules/remote_bitrate_estimator/BUILD.gn index bfa75a068d..8f983a6844 100644 --- a/webrtc/modules/remote_bitrate_estimator/BUILD.gn +++ b/webrtc/modules/remote_bitrate_estimator/BUILD.gn @@ -39,8 +39,8 @@ rtc_static_library("remote_bitrate_estimator") { defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0" ] } - if (is_clang) { - # Suppress warnings from the Chromium Clang plugins (bugs.webrtc.org/163). + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -89,8 +89,8 @@ if (rtc_include_tests) { defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0" ] } - if (is_clang) { - # Suppress warnings from the Chromium Clang plugins (bugs.webrtc.org/163). + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } diff --git a/webrtc/modules/rtp_rtcp/BUILD.gn b/webrtc/modules/rtp_rtcp/BUILD.gn index e8b7bbd437..af216e792f 100644 --- a/webrtc/modules/rtp_rtcp/BUILD.gn +++ b/webrtc/modules/rtp_rtcp/BUILD.gn @@ -165,9 +165,8 @@ rtc_static_library("rtp_rtcp") { defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0" ] } - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } diff --git a/webrtc/modules/utility/BUILD.gn b/webrtc/modules/utility/BUILD.gn index 4d177760bd..c472c3ec6a 100644 --- a/webrtc/modules/utility/BUILD.gn +++ b/webrtc/modules/utility/BUILD.gn @@ -28,9 +28,8 @@ rtc_static_library("utility") { "source/process_thread_impl.h", ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } diff --git a/webrtc/modules/video_capture/BUILD.gn b/webrtc/modules/video_capture/BUILD.gn index cd4d3c91b8..03a8d384da 100644 --- a/webrtc/modules/video_capture/BUILD.gn +++ b/webrtc/modules/video_capture/BUILD.gn @@ -33,9 +33,8 @@ rtc_static_library("video_capture_module") { "../utility", ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } @@ -51,9 +50,8 @@ rtc_static_library("video_capture") { "../../system_wrappers", ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } @@ -149,9 +147,8 @@ if (!build_with_chromium) { all_dependent_configs = [ ":video_capture_internal_impl_config" ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } @@ -192,9 +189,8 @@ if (!build_with_chromium) { ] deps += [ "//webrtc/test:test_support_main" ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } diff --git a/webrtc/modules/video_coding/BUILD.gn b/webrtc/modules/video_coding/BUILD.gn index 45ff5a7004..4836207a9f 100644 --- a/webrtc/modules/video_coding/BUILD.gn +++ b/webrtc/modules/video_coding/BUILD.gn @@ -77,9 +77,8 @@ rtc_static_library("video_coding") { # TODO(jschuh): Bug 1348: fix this warning. configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -115,9 +114,8 @@ rtc_static_library("video_coding_utility") { "utility/vp8_header_parser.h", ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -133,9 +131,8 @@ rtc_static_library("webrtc_h264") { "codecs/h264/include/h264.h", ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -205,9 +202,8 @@ if (is_ios) { "VideoToolbox.framework", ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -229,9 +225,8 @@ rtc_static_library("webrtc_i420") { "codecs/i420/include/i420.h", ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -261,9 +256,8 @@ rtc_static_library("webrtc_vp8") { # TODO(jschuh): Bug 1348: fix this warning. configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -295,9 +289,8 @@ rtc_static_library("webrtc_vp9") { ] } - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -326,9 +319,8 @@ if (rtc_include_tests) { "codecs/test/videoprocessor.h", ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } diff --git a/webrtc/modules/video_processing/BUILD.gn b/webrtc/modules/video_processing/BUILD.gn index baf2e852e2..0adbfe86d4 100644 --- a/webrtc/modules/video_processing/BUILD.gn +++ b/webrtc/modules/video_processing/BUILD.gn @@ -48,9 +48,8 @@ rtc_static_library("video_processing") { deps += [ ":video_processing_neon" ] } - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } @@ -62,9 +61,8 @@ if (build_video_processing_sse2) { "util/denoiser_filter_sse2.h", ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } diff --git a/webrtc/p2p/BUILD.gn b/webrtc/p2p/BUILD.gn index 3014617053..1b352f47bf 100644 --- a/webrtc/p2p/BUILD.gn +++ b/webrtc/p2p/BUILD.gn @@ -112,9 +112,8 @@ rtc_static_library("rtc_p2p") { "FEATURE_ENABLE_PSTN", ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } diff --git a/webrtc/pc/BUILD.gn b/webrtc/pc/BUILD.gn index be36988273..7efe1f175f 100644 --- a/webrtc/pc/BUILD.gn +++ b/webrtc/pc/BUILD.gn @@ -64,7 +64,7 @@ rtc_static_library("rtc_pc") { public_configs = [ ":rtc_pc_config" ] - if (is_clang) { + if (!build_with_chromium && is_clang) { # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -97,7 +97,7 @@ if (rtc_include_tests) { configs += [ ":rtc_pc_unittests_config" ] - if (is_clang) { + if (!build_with_chromium && is_clang) { # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } diff --git a/webrtc/sdk/BUILD.gn b/webrtc/sdk/BUILD.gn index f7c35ff883..755390c38c 100644 --- a/webrtc/sdk/BUILD.gn +++ b/webrtc/sdk/BUILD.gn @@ -194,9 +194,8 @@ if (is_ios || (is_mac && mac_deployment_target == "10.7")) { public_configs = [ ":rtc_sdk_common_objc_config" ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -287,9 +286,8 @@ if (is_ios || (is_mac && mac_deployment_target == "10.7")) { public_configs = [ ":rtc_sdk_common_objc_config" ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163) configs -= [ "//build/config/clang:find_bad_constructs" ] } } @@ -331,9 +329,8 @@ if (is_ios || (is_mac && mac_deployment_target == "10.7")) { public_configs = [ ":rtc_sdk_common_objc_config" ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163) configs -= [ "//build/config/clang:find_bad_constructs" ] } } diff --git a/webrtc/stats/BUILD.gn b/webrtc/stats/BUILD.gn index 914cb45c43..719c728a31 100644 --- a/webrtc/stats/BUILD.gn +++ b/webrtc/stats/BUILD.gn @@ -50,7 +50,7 @@ if (rtc_include_tests) { "rtcstatsreport_unittest.cc", ] - if (is_clang) { + if (!build_with_chromium && is_clang) { # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } diff --git a/webrtc/system_wrappers/BUILD.gn b/webrtc/system_wrappers/BUILD.gn index 4dd85c24fc..5033caab9f 100644 --- a/webrtc/system_wrappers/BUILD.gn +++ b/webrtc/system_wrappers/BUILD.gn @@ -208,9 +208,8 @@ if (rtc_include_tests) { configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } diff --git a/webrtc/test/BUILD.gn b/webrtc/test/BUILD.gn index 6e494c76be..5a1e71aa9a 100644 --- a/webrtc/test/BUILD.gn +++ b/webrtc/test/BUILD.gn @@ -38,9 +38,8 @@ rtc_source_set("video_test_common") { "frame_utils.h", ] - if (is_clang && !is_nacl) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -60,9 +59,8 @@ rtc_source_set("rtp_test_utils") { "rtp_file_writer.h", ] - if (is_clang && !is_nacl) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -137,9 +135,8 @@ rtc_source_set("test_support") { "//testing/gtest", ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -240,9 +237,8 @@ rtc_test("test_support_unittests") { cflags = [ "/wd4373" ] # virtual override w/different const/volatile signature. } - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -313,9 +309,8 @@ rtc_source_set("test_common") { ] } - if (is_clang && !is_nacl) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -393,9 +388,8 @@ rtc_source_set("test_renderer") { public_configs = [ ":test_renderer_exported_config" ] - if (is_clang && !is_nacl) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } diff --git a/webrtc/test/fuzzers/BUILD.gn b/webrtc/test/fuzzers/BUILD.gn index 2b0663e81d..c04a95f6ad 100644 --- a/webrtc/test/fuzzers/BUILD.gn +++ b/webrtc/test/fuzzers/BUILD.gn @@ -25,9 +25,8 @@ template("webrtc_fuzzer_test") { fuzzer_test(target_name) { forward_variables_from(invoker, "*") deps += [ ":webrtc_fuzzer_main" ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs = [ "//build/config/clang:find_bad_constructs" ] } } diff --git a/webrtc/tools/BUILD.gn b/webrtc/tools/BUILD.gn index 1ba2018a35..b94a10fab5 100644 --- a/webrtc/tools/BUILD.gn +++ b/webrtc/tools/BUILD.gn @@ -94,9 +94,8 @@ rtc_static_library("frame_editing_lib") { # TODO(jschuh): Bug 1348: fix this warning. configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -124,9 +123,8 @@ if (rtc_include_internal_audio_device) { "force_mic_volume_max/force_mic_volume_max.cc", ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -157,9 +155,8 @@ if (rtc_enable_protobuf) { "event_log_visualizer/plot_python.cc", "event_log_visualizer/plot_python.h", ] - if (is_clang && !is_nacl) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } defines = [ "ENABLE_RTC_EVENT_LOG" ] @@ -187,9 +184,8 @@ if (rtc_include_tests) { "event_log_visualizer/main.cc", ] - if (is_clang && !is_nacl) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -207,9 +203,8 @@ if (rtc_include_tests) { "agc/activity_metric.cc", ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -246,9 +241,8 @@ if (rtc_include_tests) { # TODO(jschuh): Bug 1348: fix this warning. configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } diff --git a/webrtc/video/BUILD.gn b/webrtc/video/BUILD.gn index 156c49a63e..863f2f5740 100644 --- a/webrtc/video/BUILD.gn +++ b/webrtc/video/BUILD.gn @@ -48,9 +48,8 @@ rtc_static_library("video") { "vie_remb.h", ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -99,9 +98,8 @@ if (rtc_include_tests) { "//testing/gmock", "//testing/gtest", ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } diff --git a/webrtc/voice_engine/BUILD.gn b/webrtc/voice_engine/BUILD.gn index 9b6fe0cfed..79ecca552c 100644 --- a/webrtc/voice_engine/BUILD.gn +++ b/webrtc/voice_engine/BUILD.gn @@ -76,9 +76,8 @@ rtc_static_library("voice_engine") { ] } - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -169,9 +168,8 @@ if (rtc_include_tests) { configs += [ ":channel_transport_warnings_config" ] - if (is_clang && !is_nacl) { - # Suppress warnings from the Chromium Clang plugin. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } @@ -229,9 +227,8 @@ if (rtc_include_tests) { ] } - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } @@ -254,9 +251,8 @@ if (rtc_include_tests) { "test/cmd_test/voe_cmd_test.cc", ] - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } } @@ -347,9 +343,8 @@ if (rtc_include_tests) { ] } - if (is_clang) { - # Suppress warnings from Chrome's Clang plugins. - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } }