From e40bb38faa1aed410c1591b3306feacb546888ac Mon Sep 17 00:00:00 2001 From: Jeremy Leconte Date: Fri, 25 Nov 2022 05:59:02 +0000 Subject: [PATCH] Revert "Do not log on stderr on Android tests." This reverts commit c48a2653466f926ecc1d259a16ede304333fc14b. Reason for revert: logcat issue should be fixed with https://crrev.com/c/4055461. Original change's description: > Do not log on stderr on Android tests. > > On Pixel 2, this causes an increase in flakiness. This needs to be > reenabled once the root cause is fixed. > > Bug: chromium:1384172, b/259113795 > Change-Id: Ie94d3e2daad3a2de5af673c763362ea1b42fde7d > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283522 > Reviewed-by: Jeremy Leconte > Owners-Override: Mirko Bonadei > Commit-Queue: Mirko Bonadei > Cr-Commit-Position: refs/heads/main@{#38623} Bug: chromium:1384172, b/259113795 Change-Id: Iadd7c484f4e73deea952df7980acc0164c96a592 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285021 Reviewed-by: Mirko Bonadei Owners-Override: Mirko Bonadei Commit-Queue: Jeremy Leconte Bot-Commit: rubber-stamper@appspot.gserviceaccount.com Cr-Commit-Position: refs/heads/main@{#38731} --- test/test_main_lib.cc | 6 ------ 1 file changed, 6 deletions(-) diff --git a/test/test_main_lib.cc b/test/test_main_lib.cc index e6e4615290..0ce3fb9014 100644 --- a/test/test_main_lib.cc +++ b/test/test_main_lib.cc @@ -90,13 +90,7 @@ ABSL_FLAG(bool, false, "Tells to initialize new API for exporting performance metrics"); -// TODO(crbug.com/1384172): Re-enable logs by default once the issue with -// logcat is solved. -#if defined(WEBRTC_ANDROID) -ABSL_FLAG(bool, logs, false, "print logs to stderr"); -#else ABSL_FLAG(bool, logs, true, "print logs to stderr"); -#endif ABSL_FLAG(bool, verbose, false, "verbose logs to stderr"); ABSL_FLAG(std::string,