zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert of Enable cpplint and fix cpplint errors in webrtc/*audio (patchset #4 id:180001 of https://codereview.webrtc.org/2683033004/ )

Browse Source 
Reason for revert:
The API change in audio/utility/audio_frame_operations.h caused breakage. Need to keep backward-compatible API.

Original issue's description:
> Enable cpplint and fix cpplint errors in webrtc/*audio
>
> Change usage accordingly throughout the codebase
>
> BUG=webrtc:5268
>
> TESTED=Fixed issues reported by:
> find webrtc/*audio -type f -name *.cc -o -name *.h | xargs cpplint.py
>
> Review-Url: https://codereview.webrtc.org/2683033004
> Cr-Commit-Position: refs/heads/master@{#17133}
> Committed: aebe55ca6c

TBR=henrika@webrtc.org,henrik.lundin@webrtc.org,kwiberg@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5268

Review-Url: https://codereview.webrtc.org/2739143002
Cr-Commit-Position: refs/heads/master@{#17138}
This commit is contained in:
oprypin
2017-03-09 02:43:31 -08:00
committed by Commit bot
parent f5318e1f39
commit e47c1d3ca1
33 changed files with 1068 additions and 1012 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
webrtc/common_audio/signal_processing/signal_processing_unittest.cc
View File

@ -20,11 +20,11 @@ static const int16_t vector16[kVector16Size] = {1, -15511, 4323, 1963,
class SplTest : public testing::Test {
protected:
SplTest() {
WebRtcSpl_Init();
}
virtual ~SplTest() {
}
SplTest() {
WebRtcSpl_Init();
}
virtual ~SplTest() {
}
};
TEST_F(SplTest, MacroTest) {
@ -328,8 +328,7 @@ TEST_F(SplTest, VectorOperationsTest) {
for (size_t kk = 0; kk < kVectorSize; ++kk) {
EXPECT_EQ((B[kk]*3+7)>>2, bTmp16[kk]);
}
WebRtcSpl_ScaleAndAddVectorsWithRound(b16, 3, b16, 2, 2, bTmp16,
kVectorSize);
WebRtcSpl_ScaleAndAddVectorsWithRound(b16, 3, b16, 2, 2, bTmp16, kVectorSize);
for (size_t kk = 0; kk < kVectorSize; ++kk) {
EXPECT_EQ((B[kk]*3+B[kk]*2+2)>>2, bTmp16[kk]);
}
@ -356,8 +355,7 @@ TEST_F(SplTest, VectorOperationsTest) {
for (size_t kk = 0; kk < kVectorSize; ++kk) {
EXPECT_EQ(B[kk] >> 1, bTmp16[kk]);
}
WebRtcSpl_ReverseOrderMultArrayElements(bTmp16, a16, &b16[3],
kVectorSize, 2);
WebRtcSpl_ReverseOrderMultArrayElements(bTmp16, a16, &b16[3], kVectorSize, 2);
for (size_t kk = 0; kk < kVectorSize; ++kk) {
EXPECT_EQ((a16[kk]*b16[3-kk])>>2, bTmp16[kk]);
}
@ -560,7 +558,7 @@ TEST_F(SplTest, FFTTest) {
// }
WebRtcSpl_ComplexBitReverse(B, 3);
for (int kk = 0; kk < 16; ++kk) {
// EXPECT_EQ(A[kk], B[kk]);
//EXPECT_EQ(A[kk], B[kk]);
}
}