zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Never pass a signed char to ctype macros like isdigit()

Browse Source 
Bug: None
Change-Id: I451bb2c1f175a77aefbc8363009bf35a769fe941
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264442
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37037}
This commit is contained in:
Niels Möller
2022-05-30 12:57:41 +02:00
committed by WebRTC LUCI CQ
parent c85e473740
commit e66b83f8ad
13 changed files with 11 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/audio_coding/codecs/isac/main/test/ReleaseTest-API/ReleaseTest-API.cc
View File

@ -286,7 +286,7 @@ int main(int argc, char* argv[]) {
/* Packet loss test */
if (!strcmp("-PL", argv[i])) {
if (isdigit(*argv[i + 1])) {
if (isdigit(static_cast<unsigned char>(*argv[i + 1]))) {
packetLossPercent = atoi(argv[i + 1]);
if ((packetLossPercent < 0) | (packetLossPercent > 100)) {
printf("\nInvalid packet loss perentage \n");

1
modules/audio_coding/codecs/isac/main/test/simpleKenny.c
View File

@ -22,7 +22,6 @@
#endif
#endif
#include <ctype.h>
#include <math.h>
/* include API */

8
modules/audio_coding/test/PCMFile.cc
View File

@ -62,7 +62,9 @@ int16_t PCMFile::ChooseFile(std::string* file_name,
int16_t n = 0;
// Removing trailing spaces.
while ((isspace(tmp_name[n]) || iscntrl(tmp_name[n])) && (tmp_name[n] != 0) &&
while ((isspace(static_cast<unsigned char>(tmp_name[n])) ||
iscntrl(static_cast<unsigned char>(tmp_name[n]))) &&
(static_cast<unsigned char>(tmp_name[n]) != 0) &&
(n < MAX_FILE_NAME_LENGTH_BYTE)) {
n++;
}
@ -73,7 +75,9 @@ int16_t PCMFile::ChooseFile(std::string* file_name,
// Removing trailing spaces.
n = (int16_t)(strlen(tmp_name) - 1);
if (n >= 0) {
while ((isspace(tmp_name[n]) || iscntrl(tmp_name[n])) && (n >= 0)) {
while ((isspace(static_cast<unsigned char>(tmp_name[n])) ||
iscntrl(static_cast<unsigned char>(tmp_name[n]))) &&
(n >= 0)) {
n--;
}
}

1
modules/audio_coding/test/TwoWayCommunication.cc
View File

@ -10,7 +10,6 @@
#include "TwoWayCommunication.h"
#include <ctype.h>
#include <stdio.h>
#include <string.h>

1
modules/audio_coding/test/iSACTest.cc
View File

@ -10,7 +10,6 @@
#include "modules/audio_coding/test/iSACTest.h"
#include <ctype.h>
#include <stdio.h>
#include <string.h>