From e6e7f6a4734864e17b9cd1e6940e66016bacf360 Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Fri, 15 May 2020 15:01:54 +0200 Subject: [PATCH] Reland "Re-enable absl FailureSignalHandler in tests." This is a reland of 46e9629dda1de4315b5106741cc7072b4e01548c. Relanding this one since it looks unrelated from the death tests failure, see https://bugs.chromium.org/p/webrtc/issues/detail?id=11577. Original change's description: > Re-enable absl FailureSignalHandler in tests. > > It was not the cause of the SIGSEGV on iossim, so it is fine to > re-enable it. > > TBR: titovartem@webrtc.org > Bug: None > Change-Id: I593a010f83f1a0df6b3419dd4f925380210844c9 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175105 > Commit-Queue: Mirko Bonadei > Reviewed-by: Artem Titov > Reviewed-by: Markus Handell > Cr-Commit-Position: refs/heads/master@{#31277} TBR: titovartem@webrtc.org Bug: None Change-Id: I8d57c102e175bf66819f58057dd961830c2ab094 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175345 Commit-Queue: Mirko Bonadei Reviewed-by: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#31288} --- test/test_main.cc | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/test/test_main.cc b/test/test_main.cc index 8555d5e6da..5046979548 100644 --- a/test/test_main.cc +++ b/test/test_main.cc @@ -16,11 +16,10 @@ int main(int argc, char* argv[]) { // Initialize the symbolizer to get a human-readable stack trace - // TODO(crbug.com/1050976): Breaks iossim tests, re-enable when fixed. - // absl::InitializeSymbolizer(argv[0]); + absl::InitializeSymbolizer(argv[0]); - // absl::FailureSignalHandlerOptions options; - // absl::InstallFailureSignalHandler(options); + absl::FailureSignalHandlerOptions options; + absl::InstallFailureSignalHandler(options); std::unique_ptr main = webrtc::TestMain::Create(); int err_code = main->Init(&argc, argv);