zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace RTC_DEPRECATED with ABSL_DEPRECATED

Browse Source 
This remove webrtc-specific macro that has no reason to be webrtc specific
ABSL_DEPRECATED takes a message parameter encouraging to write text how class or function is deprecated.

Bug: webrtc:12484
Change-Id: I89f1398f91dacadc37f7db469dcd985e3724e444
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208282
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33314}
This commit is contained in:
Danil Chapovalov
2021-02-22 12:43:39 +01:00
committed by Commit Bot
parent 8ef1d7b1f9
commit e904161cec
50 changed files with 63 additions and 142 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
modules/video_coding/BUILD.gn
View File

@ -186,7 +186,6 @@ rtc_library("video_coding") {
"../../common_video",
"../../rtc_base",
"../../rtc_base:checks",
"../../rtc_base:deprecation",
"../../rtc_base:rtc_base_approved",
"../../rtc_base:rtc_numerics",
"../../rtc_base:rtc_task_queue",
@ -236,7 +235,6 @@ rtc_library("video_codec_interface") {
"../../api/video_codecs:video_codecs_api",
"../../common_video",
"../../common_video/generic_frame_descriptor",
"../../rtc_base:deprecation",
"../../rtc_base/system:rtc_export",
]
absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ]
@ -487,7 +485,6 @@ rtc_library("webrtc_vp8") {
"../../api/video_codecs:vp8_temporal_layers_factory",
"../../common_video",
"../../rtc_base:checks",
"../../rtc_base:deprecation",
"../../rtc_base:rtc_base_approved",
"../../rtc_base:rtc_numerics",
"../../rtc_base/experiments:cpu_speed_experiment",

5
modules/video_coding/codecs/vp8/include/vp8.h
View File

@ -14,10 +14,10 @@
#include <memory>
#include <vector>
#include "absl/base/attributes.h"
#include "api/video_codecs/video_encoder.h"
#include "api/video_codecs/vp8_frame_buffer_controller.h"
#include "modules/video_coding/include/video_codec_interface.h"
#include "rtc_base/deprecation.h"
namespace webrtc {
@ -40,7 +40,8 @@ class VP8Encoder {
static std::unique_ptr<VideoEncoder> Create();
static std::unique_ptr<VideoEncoder> Create(Settings settings);
RTC_DEPRECATED static std::unique_ptr<VideoEncoder> Create(
ABSL_DEPRECATED("")
static std::unique_ptr<VideoEncoder> Create(
std::unique_ptr<Vp8FrameBufferControllerFactory>
frame_buffer_controller_factory);
};

2
modules/video_coding/deprecated/BUILD.gn
View File

@ -21,7 +21,6 @@ rtc_library("nack_module") {
"../../../api/units:timestamp",
"../../../rtc_base:checks",
"../../../rtc_base:criticalsection",
"../../../rtc_base:deprecation",
"../../../rtc_base:logging",
"../../../rtc_base:macromagic",
"../../../rtc_base:rtc_numerics",
@ -31,4 +30,5 @@ rtc_library("nack_module") {
"../../../system_wrappers:field_trial",
"../../utility",
]
absl_deps = [ "//third_party/abseil-cpp/absl/base:core_headers" ]
}

4
modules/video_coding/deprecated/nack_module.h
View File

@ -17,11 +17,11 @@
#include <set>
#include <vector>
#include "absl/base/attributes.h"
#include "api/units/time_delta.h"
#include "modules/include/module.h"
#include "modules/include/module_common_types.h"
#include "modules/video_coding/histogram.h"
#include "rtc_base/deprecation.h"
#include "rtc_base/numerics/sequence_number_util.h"
#include "rtc_base/synchronization/mutex.h"
#include "rtc_base/thread_annotations.h"
@ -125,7 +125,7 @@ class DEPRECATED_NackModule : public Module {
const absl::optional<BackoffSettings> backoff_settings_;
};
using NackModule = RTC_DEPRECATED DEPRECATED_NackModule;
using NackModule = ABSL_DEPRECATED("") DEPRECATED_NackModule;
} // namespace webrtc

4
modules/video_coding/include/video_codec_interface.h
View File

@ -13,6 +13,7 @@
#include <vector>
#include "absl/base/attributes.h"
#include "absl/types/optional.h"
#include "api/video/video_frame.h"
#include "api/video_codecs/video_decoder.h"
@ -21,7 +22,6 @@
#include "modules/video_coding/codecs/h264/include/h264_globals.h"
#include "modules/video_coding/codecs/vp9/include/vp9_globals.h"
#include "modules/video_coding/include/video_error_codes.h"
#include "rtc_base/deprecation.h"
#include "rtc_base/system/rtc_export.h"
namespace webrtc {
@ -79,7 +79,7 @@ struct CodecSpecificInfoVP9 {
uint8_t num_ref_pics;
uint8_t p_diff[kMaxVp9RefPics];
RTC_DEPRECATED bool end_of_picture;
ABSL_DEPRECATED("") bool end_of_picture;
};
static_assert(std::is_pod<CodecSpecificInfoVP9>::value, "");