zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace RTC_DEPRECATED with ABSL_DEPRECATED

Browse Source 
This remove webrtc-specific macro that has no reason to be webrtc specific
ABSL_DEPRECATED takes a message parameter encouraging to write text how class or function is deprecated.

Bug: webrtc:12484
Change-Id: I89f1398f91dacadc37f7db469dcd985e3724e444
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208282
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33314}
This commit is contained in:
Danil Chapovalov
2021-02-22 12:43:39 +01:00
committed by Commit Bot
parent 8ef1d7b1f9
commit e904161cec
50 changed files with 63 additions and 142 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
rtc_tools/rtc_event_log_visualizer/plot_base.h
View File

@ -15,7 +15,7 @@
#include <utility>
#include <vector>
#include "rtc_base/deprecation.h"
#include "absl/base/attributes.h"
#include "rtc_base/ignore_wundef.h"
RTC_PUSH_IGNORING_WUNDEF()
@ -101,8 +101,8 @@ class Plot {
public:
virtual ~Plot() {}
// Deprecated. Use PrintPythonCode() or ExportProtobuf() instead.
RTC_DEPRECATED virtual void Draw() {}
ABSL_DEPRECATED("Use PrintPythonCode() or ExportProtobuf() instead.")
virtual void Draw() {}
// Sets the lower x-axis limit to min_value (if left_margin == 0).
// Sets the upper x-axis limit to max_value (if right_margin == 0).
@ -189,8 +189,8 @@ class PlotCollection {
public:
virtual ~PlotCollection() {}
// Deprecated. Use PrintPythonCode() or ExportProtobuf() instead.
RTC_DEPRECATED virtual void Draw() {}
ABSL_DEPRECATED("Use PrintPythonCode() or ExportProtobuf() instead.")
virtual void Draw() {}
virtual Plot* AppendNewPlot();

7
rtc_tools/rtc_event_log_visualizer/plot_protobuf.h
View File

@ -10,6 +10,7 @@
#ifndef RTC_TOOLS_RTC_EVENT_LOG_VISUALIZER_PLOT_PROTOBUF_H_
#define RTC_TOOLS_RTC_EVENT_LOG_VISUALIZER_PLOT_PROTOBUF_H_
#include "absl/base/attributes.h"
#include "rtc_base/ignore_wundef.h"
RTC_PUSH_IGNORING_WUNDEF()
#include "rtc_tools/rtc_event_log_visualizer/proto/chart.pb.h"
@ -25,10 +26,10 @@ class ProtobufPlot final : public Plot {
void Draw() override;
};
class ProtobufPlotCollection final : public PlotCollection {
class ABSL_DEPRECATED("Use PlotCollection and ExportProtobuf() instead")
ProtobufPlotCollection final : public PlotCollection {
public:
// This class is deprecated. Use PlotCollection and ExportProtobuf() instead.
RTC_DEPRECATED ProtobufPlotCollection();
ProtobufPlotCollection();
~ProtobufPlotCollection() override;
void Draw() override;
Plot* AppendNewPlot() override;

7
rtc_tools/rtc_event_log_visualizer/plot_python.h
View File

@ -10,6 +10,7 @@
#ifndef RTC_TOOLS_RTC_EVENT_LOG_VISUALIZER_PLOT_PYTHON_H_
#define RTC_TOOLS_RTC_EVENT_LOG_VISUALIZER_PLOT_PYTHON_H_
#include "absl/base/attributes.h"
#include "rtc_tools/rtc_event_log_visualizer/plot_base.h"
namespace webrtc {
@ -21,10 +22,10 @@ class PythonPlot final : public Plot {
void Draw() override;
};
class PythonPlotCollection final : public PlotCollection {
class ABSL_DEPRECATED("Use PlotCollection and PrintPythonCode() instead.")
PythonPlotCollection final : public PlotCollection {
public:
// This class is deprecated. Use PlotCollection and PrintPythonCode() instead.
RTC_DEPRECATED explicit PythonPlotCollection(bool shared_xaxis = false);
explicit PythonPlotCollection(bool shared_xaxis = false);
~PythonPlotCollection() override;
void Draw() override;
Plot* AppendNewPlot() override;