zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert of Implement the NackModule as part of the new jitter buffer. (patchset #19 id:360001 of https://codereview.webrtc.org/1715673002/ )

Browse Source 
Reason for revert:
Unfortunately this breaks in the main waterfall: https://build.chromium.org/p/client.webrtc/builders/Android32%20Builder/builds/6362

I think it's related to dcheck_always_on=1 which is set in GYP_DEFINES only on the trybots, but not on the bots in the main waterfall.

Original issue's description:
> Implement the NackModule as part of the new jitter buffer.
>
> Things done/implemented in this CL:
>   - An interface that can send Nack (VCMNackSender).
>   - An interface that can request KeyFrames (VCMKeyFrameRequestSender).
>   - The nack module (NackModule).
>   - A set of convenience functions for modular numbers (mod_ops.h).
>
> BUG=webrtc:5514
>
> Committed: https://crrev.com/f472c5b6722dfb221f929fc4d3a2b4ca54647701
> Cr-Commit-Position: refs/heads/master@{#11882}

TBR=sprang@webrtc.org,stefan@webrtc.org,terelius@webrtc.org,torbjorng@webrtc.org,perkj@webrtc.org,tommi@webrtc.org,philipel@webrtc.org
BUG=webrtc:5514
NOTRY=True

Review URL: https://codereview.webrtc.org/1771883002

Cr-Commit-Position: refs/heads/master@{#11887}
This commit is contained in:
kjellander
2016-03-07 09:56:26 -08:00
committed by Commit bot
parent 96150a6322
commit eb648bf0e5
13 changed files with 0 additions and 1157 deletions
Download Patch File Download Diff File Expand all files Collapse all files

76
webrtc/modules/video_coding/histogram_unittest.cc
View File

@ -1,76 +0,0 @@
/*
* Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#include "testing/gtest/include/gtest/gtest.h"
#include "webrtc/modules/video_coding/histogram.h"
namespace webrtc {
namespace video_coding {
class TestHistogram : public ::testing::Test {
protected:
TestHistogram() : histogram_(5, 10) {}
Histogram histogram_;
};
TEST_F(TestHistogram, NumValues) {
EXPECT_EQ(0ul, histogram_.NumValues());
histogram_.Add(0);
EXPECT_EQ(1ul, histogram_.NumValues());
}
TEST_F(TestHistogram, InverseCdf) {
histogram_.Add(0);
histogram_.Add(1);
histogram_.Add(2);
histogram_.Add(3);
histogram_.Add(4);
EXPECT_EQ(5ul, histogram_.NumValues());
EXPECT_EQ(1ul, histogram_.InverseCdf(0.2f));
EXPECT_EQ(2ul, histogram_.InverseCdf(0.2000001f));
EXPECT_EQ(4ul, histogram_.InverseCdf(0.8f));
histogram_.Add(0);
EXPECT_EQ(6ul, histogram_.NumValues());
EXPECT_EQ(1ul, histogram_.InverseCdf(0.2f));
EXPECT_EQ(1ul, histogram_.InverseCdf(0.2000001f));
}
TEST_F(TestHistogram, ReplaceOldValues) {
histogram_.Add(0);
histogram_.Add(0);
histogram_.Add(0);
histogram_.Add(0);
histogram_.Add(0);
histogram_.Add(1);
histogram_.Add(1);
histogram_.Add(1);
histogram_.Add(1);
histogram_.Add(1);
EXPECT_EQ(10ul, histogram_.NumValues());
EXPECT_EQ(1ul, histogram_.InverseCdf(0.5f));
EXPECT_EQ(2ul, histogram_.InverseCdf(0.5000001f));
histogram_.Add(4);
histogram_.Add(4);
histogram_.Add(4);
histogram_.Add(4);
EXPECT_EQ(10ul, histogram_.NumValues());
EXPECT_EQ(1ul, histogram_.InverseCdf(0.1f));
EXPECT_EQ(2ul, histogram_.InverseCdf(0.5f));
histogram_.Add(20);
EXPECT_EQ(10ul, histogram_.NumValues());
EXPECT_EQ(2ul, histogram_.InverseCdf(0.5f));
EXPECT_EQ(5ul, histogram_.InverseCdf(0.5000001f));
}
} // namespace video_coding
} // namespace webrtc