zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

This is an initial cleanup step, aiming to delete the

Browse Source 
webrtc::VideoRenderer class, replacing it by rtc::VideoSinkInterface.

The next step is to convert all places where a renderer is attached to
rtc::VideoSourceInterface, and at that point, the
SmoothsRenderedFrames method can be replaced by a flag
rtc::VideoSinkWants::smoothed_frames.

Delete unused method IsTextureSupported.
Delete unused time argument to RenderFrame.
Let webrtc::VideoRenderer inherit rtc::VideoSinkInterface. Rename RenderFrame --> OnFrame.

TBR=kjellander@webrtc.org
BUG=webrtc:5426

Review URL: https://codereview.webrtc.org/1814763002

Cr-Commit-Position: refs/heads/master@{#12070}
This commit is contained in:
nisse
2016-03-21 01:27:56 -07:00
committed by Commit bot
parent 105831ef4a
commit eb83a1a10f
22 changed files with 40 additions and 105 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
webrtc/call/call_perf_tests.cc
View File

@ -88,8 +88,7 @@ class VideoRtcpAndSyncObserver : public test::RtpRtcpObserver,
first_time_in_sync_(-1),
receive_stream_(nullptr) {}
void RenderFrame(const VideoFrame& video_frame,
int time_to_render_ms) override {
void OnFrame(const VideoFrame& video_frame) override {
VideoReceiveStream::Stats stats;
{
rtc::CritScope lock(&crit_);
@ -129,8 +128,6 @@ class VideoRtcpAndSyncObserver : public test::RtpRtcpObserver,
}
}
bool IsTextureSupported() const override { return false; }
void set_receive_stream(VideoReceiveStream* receive_stream) {
rtc::CritScope lock(&crit_);
receive_stream_ = receive_stream;
@ -377,8 +374,7 @@ void CallPerfTest::TestCaptureNtpTime(const FakeNetworkPipe::Config& net_config,
nullptr, this, test::PacketTransport::kReceiver, net_config_);
}
void RenderFrame(const VideoFrame& video_frame,
int time_to_render_ms) override {
void OnFrame(const VideoFrame& video_frame) override {
rtc::CritScope lock(&crit_);
if (video_frame.ntp_time_ms() <= 0) {
// Haven't got enough RTCP SR in order to calculate the capture ntp
@ -417,8 +413,6 @@ void CallPerfTest::TestCaptureNtpTime(const FakeNetworkPipe::Config& net_config,
EXPECT_TRUE(std::abs(time_offset_ms) < threshold_ms_);
}
bool IsTextureSupported() const override { return false; }
virtual Action OnSendRtp(const uint8_t* packet, size_t length) {
rtc::CritScope lock(&crit_);
RTPHeader header;