zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixes race in SendSideCongestionControllerTest.OldFeedback.

Browse Source 
This fixes an issue where SendSideCongestionControllerTest.OldFeedback
calls a function that posts a task on a TaskQueue and immediately after
changes the mocked observer that is called from that task.

Bug: webrtc:10056
Change-Id: Ib1cca5bf695482e75106bfc715662e4f76c381d9
Reviewed-on: https://webrtc-review.googlesource.com/c/112940
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25882}
This commit is contained in:
Sebastian Jansson
2018-12-03 17:46:21 +01:00
committed by Commit Bot
parent ec0f45be11
commit ec086d842c
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/congestion_controller/rtp/send_side_congestion_controller_unittest.cc
View File

@ -302,7 +302,7 @@ TEST_F(SendSideCongestionControllerTest, OldFeedback) {
feedback.Build(); feedback.Build();
controller_->OnTransportFeedback(feedback); controller_->OnTransportFeedback(feedback);
} }
controller_->WaitOnTasks();
// If the bitrate is reset to -1, the new starting bitrate will be // If the bitrate is reset to -1, the new starting bitrate will be
// the minimum default bitrate kMinBitrateBps. // the minimum default bitrate kMinBitrateBps.
EXPECT_CALL( EXPECT_CALL(