Reland of Add arraysize to rtc_base_approved. Remove dependency of audio_device on rtc_base. (patchset #1 id:1 of https://codereview.webrtc.org/2340253003/ )
Reason for revert: Fix: let audio_device depend on rtc_base on IOS. Original issue's description: > Revert of Add arraysize to rtc_base_approved. Remove dependency of audio_device on rtc_base. (patchset #1 id:1 of https://codereview.webrtc.org/2346763002/ ) > > Reason for revert: > Breaks iOS > > Original issue's description: > > Add arraysize to rtc_base_approved. Remove dependency of audio_device on rtc_base. > > > > BUG=webrtc:3806 > > NOTRY=True > > > > Committed: https://crrev.com/100c9d02669910bce06099b3cc1eaad60fd661dd > > Cr-Commit-Position: refs/heads/master@{#14223} > > TBR=kjellander@webrtc.org,henrika@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:3806 > > Committed: https://crrev.com/89fb9201b70616a1c33e277f38bf9367112536e8 > Cr-Commit-Position: refs/heads/master@{#14224} TBR=kjellander@webrtc.org,henrika@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOTRY=true BUG=webrtc:3806 Review-Url: https://codereview.webrtc.org/2340233003 Cr-Commit-Position: refs/heads/master@{#14233}
This commit is contained in:
@ -235,6 +235,7 @@ def _CheckNoRtcBaseDeps(input_api, gyp_files, output_api):
|
||||
violating_files = []
|
||||
for f in gyp_files:
|
||||
gyp_exceptions = (
|
||||
'audio_device.gypi',
|
||||
'base_tests.gyp',
|
||||
'desktop_capture.gypi',
|
||||
'p2p.gyp',
|
||||
@ -260,6 +261,7 @@ def _CheckNoRtcBaseDepsGn(input_api, gn_files, output_api):
|
||||
violating_files = []
|
||||
for f in gn_files:
|
||||
gn_exceptions = (
|
||||
os.path.join('audio_device', 'BUILD.gn'),
|
||||
os.path.join('base_tests', 'BUILD.gn'),
|
||||
os.path.join('desktop_capture', 'BUILD.gn'),
|
||||
os.path.join('p2p', 'BUILD.gn'),
|
||||
|
||||
Reference in New Issue
Block a user