From ec93075c00b876816c310a76654d8f20a73f11be Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20M=C3=B6ller?= Date: Wed, 22 Aug 2018 14:22:58 +0200 Subject: [PATCH] Delete deprecated methods on AudioCodingModule Bug: None Change-Id: I05f1ab6cdd6ac52972835af7ea94aacf5f64d673 Reviewed-on: https://webrtc-review.googlesource.com/95482 Reviewed-by: Henrik Lundin Commit-Queue: Niels Moller Cr-Commit-Position: refs/heads/master@{#24388} --- .../audio_coding/acm2/audio_coding_module.cc | 19 --------------- .../include/audio_coding_module.h | 23 ------------------- 2 files changed, 42 deletions(-) diff --git a/modules/audio_coding/acm2/audio_coding_module.cc b/modules/audio_coding/acm2/audio_coding_module.cc index 7f652a215d..92a4a9d5b0 100644 --- a/modules/audio_coding/acm2/audio_coding_module.cc +++ b/modules/audio_coding/acm2/audio_coding_module.cc @@ -158,8 +158,6 @@ class AudioCodingModuleImpl final : public AudioCodingModule { // Smallest latency NetEq will maintain. int LeastRequiredDelayMs() const override; - RTC_DEPRECATED int32_t PlayoutTimestamp(uint32_t* timestamp) override; - absl::optional PlayoutTimestamp() override; int FilteredCurrentDelayMs() const override; @@ -171,7 +169,6 @@ class AudioCodingModuleImpl final : public AudioCodingModule { int PlayoutData10Ms(int desired_freq_hz, AudioFrame* audio_frame, bool* muted) override; - int PlayoutData10Ms(int desired_freq_hz, AudioFrame* audio_frame) override; ///////////////////////////////////////// // Statistics @@ -1109,14 +1106,6 @@ int AudioCodingModuleImpl::PlayoutData10Ms(int desired_freq_hz, return 0; } -int AudioCodingModuleImpl::PlayoutData10Ms(int desired_freq_hz, - AudioFrame* audio_frame) { - bool muted; - int ret = PlayoutData10Ms(desired_freq_hz, audio_frame, &muted); - RTC_DCHECK(!muted); - return ret; -} - ///////////////////////////////////////// // Statistics // @@ -1181,14 +1170,6 @@ int AudioCodingModuleImpl::DisableOpusDtx() { return encoder_stack_->SetDtx(false) ? 0 : -1; } -int32_t AudioCodingModuleImpl::PlayoutTimestamp(uint32_t* timestamp) { - absl::optional ts = PlayoutTimestamp(); - if (!ts) - return -1; - *timestamp = *ts; - return 0; -} - absl::optional AudioCodingModuleImpl::PlayoutTimestamp() { return receiver_.GetPlayoutTimestamp(); } diff --git a/modules/audio_coding/include/audio_coding_module.h b/modules/audio_coding/include/audio_coding_module.h index 41745abc7b..85e340bba7 100644 --- a/modules/audio_coding/include/audio_coding_module.h +++ b/modules/audio_coding/include/audio_coding_module.h @@ -21,7 +21,6 @@ #include "common_types.h" // NOLINT(build/include) #include "modules/audio_coding/include/audio_coding_module_typedefs.h" #include "modules/audio_coding/neteq/include/neteq.h" -#include "rtc_base/deprecation.h" #include "rtc_base/function_view.h" #include "system_wrappers/include/clock.h" @@ -612,20 +611,6 @@ class AudioCodingModule { // virtual int LeastRequiredDelayMs() const = 0; - // int32_t PlayoutTimestamp() - // The send timestamp of an RTP packet is associated with the decoded - // audio of the packet in question. This function returns the timestamp of - // the latest audio obtained by calling PlayoutData10ms(). - // - // Input: - // -timestamp : a reference to a uint32_t to receive the - // timestamp. - // Return value: - // 0 if the output is a correct timestamp. - // -1 if failed to output the correct timestamp. - // - RTC_DEPRECATED virtual int32_t PlayoutTimestamp(uint32_t* timestamp) = 0; - /////////////////////////////////////////////////////////////////////////// // int32_t PlayoutTimestamp() // The send timestamp of an RTP packet is associated with the decoded @@ -674,14 +659,6 @@ class AudioCodingModule { AudioFrame* audio_frame, bool* muted) = 0; - ///////////////////////////////////////////////////////////////////////////// - // Same as above, but without the muted parameter. This methods should not be - // used if enable_fast_accelerate was set to true in NetEq::Config. - // TODO(henrik.lundin) Remove this method when downstream dependencies are - // ready. - virtual int32_t PlayoutData10Ms(int32_t desired_freq_hz, - AudioFrame* audio_frame) = 0; - /////////////////////////////////////////////////////////////////////////// // Codec specific //