zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removes unused WaveOut APIs from ADM.

Browse Source 
Will remove default implementations as well once landed and removed
in Chrome as well.

These two AudioDeviceModule APIs are removed:

int32_t SetWaveOutVolume(uint16_t volumeLeft, uint16_t volumeRight)
int32_t WaveOutVolume(uint16_t* volumeLeft, uint16_t* volumeRight) const

BUG=webrtc:7306

Review-Url: https://codereview.webrtc.org/3006793002
Cr-Commit-Position: refs/heads/master@{#19581}
This commit is contained in:
henrika
2017-08-29 06:02:10 -07:00
committed by Commit Bot
parent 9b2f20c618
commit ecf312e603
24 changed files with 4 additions and 222 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
webrtc/modules/audio_device/linux/audio_device_alsa_linux.cc
View File

@ -321,24 +321,6 @@ int32_t AudioDeviceLinuxALSA::SpeakerVolume(uint32_t& volume) const
return 0;
}
int32_t AudioDeviceLinuxALSA::SetWaveOutVolume(uint16_t volumeLeft,
uint16_t volumeRight)
{
LOG(LS_WARNING) << "API call not supported on this platform";
return -1;
}
int32_t AudioDeviceLinuxALSA::WaveOutVolume(
uint16_t& /*volumeLeft*/,
uint16_t& /*volumeRight*/) const
{
LOG(LS_WARNING) << "API call not supported on this platform";
return -1;
}
int32_t AudioDeviceLinuxALSA::MaxSpeakerVolume(
uint32_t& maxVolume) const
{

6
webrtc/modules/audio_device/linux/audio_device_alsa_linux.h
View File

@ -83,12 +83,6 @@ public:
int32_t SetAGC(bool enable) override;
bool AGC() const override;
// Volume control based on the Windows Wave API (Windows only)
int32_t SetWaveOutVolume(uint16_t volumeLeft,
uint16_t volumeRight) override;
int32_t WaveOutVolume(uint16_t& volumeLeft,
uint16_t& volumeRight) const override;
// Audio mixer initialization
int32_t InitSpeaker() override;
bool SpeakerIsInitialized() const override;

12
webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc
View File

@ -372,18 +372,6 @@ int32_t AudioDeviceLinuxPulse::SpeakerVolume(uint32_t& volume) const {
return 0;
}
int32_t AudioDeviceLinuxPulse::SetWaveOutVolume(uint16_t volumeLeft,
uint16_t volumeRight) {
LOG(LS_WARNING) << "API call not supported on this platform";
return -1;
}
int32_t AudioDeviceLinuxPulse::WaveOutVolume(uint16_t& /*volumeLeft*/,
uint16_t& /*volumeRight*/) const {
LOG(LS_WARNING) << "API call not supported on this platform";
return -1;
}
int32_t AudioDeviceLinuxPulse::MaxSpeakerVolume(uint32_t& maxVolume) const {
RTC_DCHECK(thread_checker_.CalledOnValidThread());
uint32_t maxVol(0);

6
webrtc/modules/audio_device/linux/audio_device_pulse_linux.h
View File

@ -145,12 +145,6 @@ public:
int32_t SetAGC(bool enable) override;
bool AGC() const override;
// Volume control based on the Windows Wave API (Windows only)
int32_t SetWaveOutVolume(uint16_t volumeLeft,
uint16_t volumeRight) override;
int32_t WaveOutVolume(uint16_t& volumeLeft,
uint16_t& volumeRight) const override;
// Audio mixer initialization
int32_t InitSpeaker() override;
bool SpeakerIsInitialized() const override;