diff --git a/api/call/transport.cc b/api/call/transport.cc index 515f27c3f7..0a9dd5bcc7 100644 --- a/api/call/transport.cc +++ b/api/call/transport.cc @@ -14,6 +14,8 @@ namespace webrtc { PacketOptions::PacketOptions() = default; +PacketOptions::PacketOptions(const PacketOptions&) = default; + PacketOptions::~PacketOptions() = default; } // namespace webrtc diff --git a/api/call/transport.h b/api/call/transport.h index 5cb6b3007c..18d22705cd 100644 --- a/api/call/transport.h +++ b/api/call/transport.h @@ -21,6 +21,7 @@ namespace webrtc { // asyncpacketsocket.h. struct PacketOptions { PacketOptions(); + PacketOptions(const PacketOptions&); ~PacketOptions(); // A 16 bits positive id. Negative ids are invalid and should be interpreted diff --git a/call/BUILD.gn b/call/BUILD.gn index 45d6ef16c3..43b4ce6b2f 100644 --- a/call/BUILD.gn +++ b/call/BUILD.gn @@ -161,10 +161,6 @@ rtc_source_set("bitrate_allocator") { "../system_wrappers:field_trial_api", "../system_wrappers:metrics_api", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_static_library("call") { @@ -265,11 +261,6 @@ rtc_source_set("fake_network") { "../system_wrappers", "//third_party/abseil-cpp/absl/memory", ] - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } if (rtc_include_tests) { @@ -438,9 +429,5 @@ if (rtc_include_tests) { sources = [ "test/fake_network_pipe_unittest.cc", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } } diff --git a/call/fake_network_pipe.cc b/call/fake_network_pipe.cc index cc15915ef4..9c1ba429fc 100644 --- a/call/fake_network_pipe.cc +++ b/call/fake_network_pipe.cc @@ -53,6 +53,8 @@ NetworkPacket::NetworkPacket(NetworkPacket&& o) media_type_(o.media_type_), packet_time_(o.packet_time_) {} +NetworkPacket::~NetworkPacket() = default; + NetworkPacket& NetworkPacket::operator=(NetworkPacket&& o) { packet_ = std::move(o.packet_); send_time_ = o.send_time_; @@ -147,6 +149,8 @@ SimulatedNetwork::SimulatedNetwork(SimulatedNetwork::Config config, SetConfig(config); } +SimulatedNetwork::~SimulatedNetwork() = default; + void FakeNetworkPipe::SetConfig(const FakeNetworkPipe::Config& config) { network_simulation_->SetConfig(config); } diff --git a/call/fake_network_pipe.h b/call/fake_network_pipe.h index d7c042dc84..e4ebe2c577 100644 --- a/call/fake_network_pipe.h +++ b/call/fake_network_pipe.h @@ -46,6 +46,7 @@ class NetworkPacket { absl::optional packet_time_); // Disallow copy constructor and copy assignment (no deep copies of |data_|). NetworkPacket(const NetworkPacket&) = delete; + ~NetworkPacket(); NetworkPacket& operator=(const NetworkPacket&) = delete; // Allow move constructor/assignment, so that we can use in stl containers. NetworkPacket(NetworkPacket&&); @@ -91,6 +92,7 @@ class SimulatedNetwork : public NetworkSimulationInterface { public: using Config = NetworkSimulationInterface::SimulatedNetworkConfig; explicit SimulatedNetwork(Config config, uint64_t random_seed = 1); + ~SimulatedNetwork() override; // Sets a new configuration. This won't affect packets already in the pipe. void SetConfig(const Config& config); @@ -153,7 +155,7 @@ class FakeNetworkPipe : public Transport, public PacketReceiver, public Module { const FakeNetworkPipe::Config& config, Transport* transport); - virtual ~FakeNetworkPipe(); + ~FakeNetworkPipe() override; void SetClockOffset(int64_t offset_ms);