zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove deprecated RtcEventLog Create functions

Browse Source 
Bug: webrtc:10206
Change-Id: Iabf3eea20027ae42faadabba572dc68f9b678121
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/139105
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28103}
This commit is contained in:
Danil Chapovalov
2019-05-29 10:24:36 +02:00
committed by Commit Bot
parent 2f5554dae5
commit ed69d41b62
3 changed files with 1 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
api/rtc_event_log/BUILD.gn
View File

@ -21,10 +21,8 @@ rtc_source_set("rtc_event_log") {
deps = [ deps = [
"..:libjingle_logging_api", "..:libjingle_logging_api",
"../../rtc_base:checks", "../../rtc_base:checks",
"../../rtc_base:deprecation",
"../../rtc_base:timeutils", "../../rtc_base:timeutils",
"../task_queue", "../task_queue",
"//third_party/abseil-cpp/absl/memory",
] ]
} }

18
api/rtc_event_log/rtc_event_log.h
View File

@ -13,13 +13,12 @@
#include <cstddef> #include <cstddef>
#include <cstdint> #include <cstdint>
#include <functional>
#include <memory> #include <memory>
#include "absl/memory/memory.h"
#include "api/rtc_event_log/rtc_event.h" #include "api/rtc_event_log/rtc_event.h"
#include "api/rtc_event_log_output.h" #include "api/rtc_event_log_output.h"
#include "api/task_queue/task_queue_factory.h" #include "api/task_queue/task_queue_factory.h"
#include "rtc_base/deprecation.h"
namespace webrtc { namespace webrtc {
@ -32,17 +31,6 @@ class RtcEventLog {
// clients have migrated to the new format. // clients have migrated to the new format.
enum class EncodingType { Legacy, NewFormat }; enum class EncodingType { Legacy, NewFormat };
// Factory method to create an RtcEventLog object.
// Create RtcEventLog with an RtcEventLogFactory instead.
RTC_DEPRECATED
static std::unique_ptr<RtcEventLog> Create(
EncodingType encoding_type,
TaskQueueFactory* task_queue_factory);
// Create an RtcEventLog object that does nothing.
RTC_DEPRECATED
static std::unique_ptr<RtcEventLog> CreateNull();
virtual ~RtcEventLog() = default; virtual ~RtcEventLog() = default;
// Starts logging to a given output. The output might be limited in size, // Starts logging to a given output. The output might be limited in size,
@ -76,10 +64,6 @@ class RtcEventLogNull final : public RtcEventLog {
void Log(std::unique_ptr<RtcEvent> event) override {} void Log(std::unique_ptr<RtcEvent> event) override {}
}; };
inline std::unique_ptr<RtcEventLog> RtcEventLog::CreateNull() {
return absl::make_unique<RtcEventLogNull>();
}
} // namespace webrtc } // namespace webrtc
#endif // API_RTC_EVENT_LOG_RTC_EVENT_LOG_H_ #endif // API_RTC_EVENT_LOG_RTC_EVENT_LOG_H_

6
api/rtc_event_log/rtc_event_log_factory.cc
View File

@ -35,10 +35,4 @@ std::unique_ptr<RtcEventLog> RtcEventLogFactory::CreateRtcEventLog(
#endif #endif
} }
std::unique_ptr<RtcEventLog> RtcEventLog::Create(
RtcEventLog::EncodingType encoding_type,
TaskQueueFactory* task_queue_factory) {
return RtcEventLogFactory(task_queue_factory)
.CreateRtcEventLog(encoding_type);
}
} // namespace webrtc } // namespace webrtc