zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace ASSERT by RTC_DCHECK in all non-test code.

Browse Source 
Bulk of the changes were produced using

  git grep -l ' ASSERT(' | grep -v test | grep -v 'common\.h' |\
    xargs -n1 sed -i 's/ ASSERT(/ RTC_DCHECK(/'

followed by additional includes of base/checks.h in affected files,
and git cl format.

Also had to do some tweaks to #if !defined(NDEBUG) logic in the
taskrunner code (webrtc/base/task.cc, webrtc/base/taskparent.cc,
webrtc/base/taskparent.h, webrtc/base/taskrunner.cc), replaced to
consistently use RTC_DCHECK_IS_ON, and some of the checks needed
additional #if protection.

Test code was excluded, because it should probably use RTC_CHECK
rather than RTC_DCHECK.

BUG=webrtc:6424

Review-Url: https://codereview.webrtc.org/2620303003
Cr-Commit-Position: refs/heads/master@{#16030}
This commit is contained in:
nisse
2017-01-12 05:15:36 -08:00
committed by Commit bot
parent 59e99b76da
commit ede5da4960
88 changed files with 686 additions and 631 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
webrtc/base/asyncudpsocket.cc
View File

@ -9,6 +9,7 @@
*/
#include "webrtc/base/asyncudpsocket.h"
#include "webrtc/base/checks.h"
#include "webrtc/base/logging.h"
namespace rtc {
@ -99,7 +100,7 @@ void AsyncUDPSocket::SetError(int error) {
}
void AsyncUDPSocket::OnReadEvent(AsyncSocket* socket) {
ASSERT(socket_.get() == socket);
RTC_DCHECK(socket_.get() == socket);
SocketAddress remote_addr;
int64_t timestamp;