zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix platform-specific header dependencies to be more precise

Browse Source 
Make the GN conditionals match what happens in sources, or the other way around. Include headers only when they're used.

Bug: None
Change-Id: Ib8e3346e3c24eaa7e61ac4776dcd66efe2cc5c65
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144880
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28500}
This commit is contained in:
Oleh Prypin
2019-07-08 09:47:41 +02:00
committed by Commit Bot
parent 86f8b3bd5d
commit eec86cdd96
4 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
examples/objc/AppRTCMobile/ios/ARDVideoCallView.m
View File

@ -13,7 +13,9 @@
#import <AVFoundation/AVFoundation.h> #import <AVFoundation/AVFoundation.h>
#import <WebRTC/RTCEAGLVideoView.h> #import <WebRTC/RTCEAGLVideoView.h>
#if defined(RTC_SUPPORTS_METAL)
#import <WebRTC/RTCMTLVideoView.h> #import <WebRTC/RTCMTLVideoView.h>
#endif
#import "UIImage+ARDUtilities.h" #import "UIImage+ARDUtilities.h"

5
modules/audio_processing/BUILD.gn
View File

@ -302,7 +302,9 @@ rtc_source_set("file_audio_generator") {
rtc_source_set("audio_processing_c") { rtc_source_set("audio_processing_c") {
visibility = [ ":*" ] # Only targets in this file can depend on this. visibility = [ ":*" ] # Only targets in this file can depend on this.
sources = [] sources = [
"ns/windows_private.h",
]
if (rtc_prefer_fixed_point) { if (rtc_prefer_fixed_point) {
sources += [ sources += [
@ -324,7 +326,6 @@ rtc_source_set("audio_processing_c") {
"ns/noise_suppression.h", "ns/noise_suppression.h",
"ns/ns_core.c", "ns/ns_core.c",
"ns/ns_core.h", "ns/ns_core.h",
"ns/windows_private.h",
] ]
} }

8
modules/video_processing/util/denoiser_filter.cc
View File

@ -10,12 +10,16 @@
#include "modules/video_processing/util/denoiser_filter.h" #include "modules/video_processing/util/denoiser_filter.h"
#include "modules/video_processing/util/denoiser_filter_c.h" #include "modules/video_processing/util/denoiser_filter_c.h"
#include "modules/video_processing/util/denoiser_filter_neon.h"
#include "modules/video_processing/util/denoiser_filter_sse2.h"
#include "rtc_base/checks.h" #include "rtc_base/checks.h"
#include "rtc_base/system/arch.h" #include "rtc_base/system/arch.h"
#include "system_wrappers/include/cpu_features_wrapper.h" #include "system_wrappers/include/cpu_features_wrapper.h"
#if defined(WEBRTC_ARCH_X86_FAMILY)
#include "modules/video_processing/util/denoiser_filter_sse2.h"
#elif defined(WEBRTC_HAS_NEON)
#include "modules/video_processing/util/denoiser_filter_neon.h"
#endif
namespace webrtc { namespace webrtc {
const int kMotionMagnitudeThreshold = 8 * 3; const int kMotionMagnitudeThreshold = 8 * 3;

4
test/testsupport/file_utils.cc
View File

@ -48,9 +48,7 @@
#if defined(WEBRTC_IOS) #if defined(WEBRTC_IOS)
#include "test/testsupport/ios_file_utils.h" #include "test/testsupport/ios_file_utils.h"
#endif #elif defined(WEBRTC_MAC)
#if defined(WEBRTC_MAC)
#include "test/testsupport/mac_file_utils.h" #include "test/testsupport/mac_file_utils.h"
#endif #endif