zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dcsctp: Convert socket tests not to use fixtures

Browse Source 
Following https://abseil.io/tips/122 to make tests easier to understand
and adds a bit of flexibility to create sockets with custom parameters.
This also simplifies handover tests.

Additionally, AdvanceTime will now also run timers, as that was easily
forgotten previously.

Bug: None
Change-Id: Ieb5eece7aca51c98a7634ed1c61646383ad1712d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253782
Reviewed-by: Sergey Sukhanov <sergeysu@webrtc.org>
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36141}
This commit is contained in:
Victor Boivie
2022-03-04 20:11:44 +01:00
committed by WebRTC LUCI CQ
parent 0f50cc2849
commit eee0e336a2
3 changed files with 891 additions and 795 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1608
net/dcsctp/socket/dcsctp_socket_test.cc
View File

File diff suppressed because it is too large Load Diff

6
net/dcsctp/socket/mock_dcsctp_socket_callbacks.h
View File

@ -153,12 +153,6 @@ class MockDcSctpSocketCallbacks : public DcSctpSocketCallbacks {
return timeout_manager_.GetNextExpiredTimeout();
}
void Reset() {
sent_packets_.clear();
received_messages_.clear();
timeout_manager_.Reset();
}
private:
const std::string log_prefix_;
TimeMs now_ = TimeMs(0);

2
net/dcsctp/timer/fake_timeout.h
View File

@ -97,8 +97,6 @@ class FakeTimeoutManager {
return absl::nullopt;
}
void Reset() { timers_.clear(); }
private:
const std::function<TimeMs()> get_time_;
webrtc::flat_set<FakeTimeout*> timers_;