zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Stats] Cleanup obsolete stats - isRemote & deleted

Browse Source 
Deleting obsolete stats. Spec: https://www.w3.org/TR/webrtc-stats/

1. RTCInbound/OutboundRtpStats.isRemote: No longer useful with remote stream stats
2. RTCIceCandidateStats.deleted: This field was obsoleted because if the ICE candidate is deleted it no longer appears in getStats()

I also marked as many other obsoleted stats possible according to spec. I am not as confident to delete them but feel free to comment to let me know if anything is off / can be deleted.

Bug: webrtc:12583
Change-Id: I688d0076270f85caa86256349753e5f0e0a44931
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/211781
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33549}
This commit is contained in:
Di Wu
2021-03-19 08:24:41 -07:00
committed by Commit Bot
parent 56db9ff1e1
commit ef036cdff2
5 changed files with 12 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
stats/rtcstats_objects.cc
View File

@ -265,8 +265,7 @@ WEBRTC_RTCSTATS_IMPL(RTCIceCandidateStats, RTCStats, "abstract-ice-candidate",
&relay_protocol,
&candidate_type,
&priority,
&url,
&deleted)
&url)
// clang-format on
RTCIceCandidateStats::RTCIceCandidateStats(const std::string& id,
@ -288,8 +287,7 @@ RTCIceCandidateStats::RTCIceCandidateStats(std::string&& id,
relay_protocol("relayProtocol"),
candidate_type("candidateType"),
priority("priority"),
url("url"),
deleted("deleted", false) {}
url("url") {}
RTCIceCandidateStats::RTCIceCandidateStats(const RTCIceCandidateStats& other)
: RTCStats(other.id(), other.timestamp_us()),
@ -303,8 +301,7 @@ RTCIceCandidateStats::RTCIceCandidateStats(const RTCIceCandidateStats& other)
relay_protocol(other.relay_protocol),
candidate_type(other.candidate_type),
priority(other.priority),
url(other.url),
deleted(other.deleted) {}
url(other.url) {}
RTCIceCandidateStats::~RTCIceCandidateStats() {}
@ -679,8 +676,7 @@ WEBRTC_RTCSTATS_IMPL(
&fir_count,
&pli_count,
&nack_count,
&qp_sum,
&is_remote)
&qp_sum)
// clang-format on
RTCInboundRTPStreamStats::RTCInboundRTPStreamStats(const std::string& id,
@ -736,8 +732,7 @@ RTCInboundRTPStreamStats::RTCInboundRTPStreamStats(std::string&& id,
fir_count("firCount"),
pli_count("pliCount"),
nack_count("nackCount"),
qp_sum("qpSum"),
is_remote("isRemote") {}
qp_sum("qpSum") {}
RTCInboundRTPStreamStats::RTCInboundRTPStreamStats(
const RTCInboundRTPStreamStats& other)
@ -789,8 +784,7 @@ RTCInboundRTPStreamStats::RTCInboundRTPStreamStats(
fir_count(other.fir_count),
pli_count(other.pli_count),
nack_count(other.nack_count),
qp_sum(other.qp_sum),
is_remote(other.is_remote) {}
qp_sum(other.qp_sum) {}
RTCInboundRTPStreamStats::~RTCInboundRTPStreamStats() {}
@ -823,8 +817,7 @@ WEBRTC_RTCSTATS_IMPL(
&fir_count,
&pli_count,
&nack_count,
&qp_sum,
&is_remote)
&qp_sum)
// clang-format on
RTCOutboundRTPStreamStats::RTCOutboundRTPStreamStats(const std::string& id,
@ -861,8 +854,7 @@ RTCOutboundRTPStreamStats::RTCOutboundRTPStreamStats(std::string&& id,
fir_count("firCount"),
pli_count("pliCount"),
nack_count("nackCount"),
qp_sum("qpSum"),
is_remote("isRemote") {}
qp_sum("qpSum") {}
RTCOutboundRTPStreamStats::RTCOutboundRTPStreamStats(
const RTCOutboundRTPStreamStats& other)
@ -894,8 +886,7 @@ RTCOutboundRTPStreamStats::RTCOutboundRTPStreamStats(
fir_count(other.fir_count),
pli_count(other.pli_count),
nack_count(other.nack_count),
qp_sum(other.qp_sum),
is_remote(other.is_remote) {}
qp_sum(other.qp_sum) {}
RTCOutboundRTPStreamStats::~RTCOutboundRTPStreamStats() {}