zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed crash when PCF is destroyed before RTCRtpSender in ObjC

Browse Source 
Bug: webrtc:9231
Change-Id: I3b90400bf619938817d7a04a7a1130ba86ad65df
Reviewed-on: https://webrtc-review.googlesource.com/87623
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23896}
This commit is contained in:
Yura Yaroshevich
2018-07-09 19:16:32 +03:00
committed by Commit Bot
parent bd216f2854
commit ef43aafcf5
5 changed files with 45 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
sdk/objc/Framework/Classes/PeerConnection/RTCRtpSender.mm
View File

@ -19,6 +19,7 @@
#include "api/mediastreaminterface.h"
@implementation RTCRtpSender {
RTCPeerConnectionFactory *_factory;
rtc::scoped_refptr<webrtc::RtpSenderInterface> _nativeRtpSender;
}
@ -84,10 +85,12 @@
return _nativeRtpSender;
}
- (instancetype)initWithNativeRtpSender:
(rtc::scoped_refptr<webrtc::RtpSenderInterface>)nativeRtpSender {
- (instancetype)initWithFactory:(RTCPeerConnectionFactory *)factory
nativeRtpSender:(rtc::scoped_refptr<webrtc::RtpSenderInterface>)nativeRtpSender {
NSParameterAssert(factory);
NSParameterAssert(nativeRtpSender);
if (self = [super init]) {
_factory = factory;
_nativeRtpSender = nativeRtpSender;
rtc::scoped_refptr<webrtc::DtmfSenderInterface> nativeDtmfSender(
_nativeRtpSender->GetDtmfSender());