Enable -Winconsistent-missing-override flag.
The problem with gmock is worked around by commenting out any other override declarations in classes using gmock. NOPRESUBMIT=True BUG=webrtc:3970 Review-Url: https://codereview.webrtc.org/1921653002 Cr-Commit-Position: refs/heads/master@{#12563}
This commit is contained in:
@ -424,8 +424,8 @@ class MockPeerConnectionObserver : public PeerConnectionObserver {
|
||||
state_ = pc_->signaling_state();
|
||||
}
|
||||
}
|
||||
virtual void OnSignalingChange(
|
||||
PeerConnectionInterface::SignalingState new_state) {
|
||||
void OnSignalingChange(
|
||||
PeerConnectionInterface::SignalingState new_state) override {
|
||||
EXPECT_EQ(pc_->signaling_state(), new_state);
|
||||
state_ = new_state;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user