zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Extracted rtp receiver payload management to its own class, made video receiver depend on that instead.

Browse Source 
Eliminated need for video receiver to talk to its parent. Also we will now determine if the packet is the first one already in the rtp general receiver. The possible downside would be that recovered video packets no longer can be flagged as the first packet, but I don't think that can happen. Even if it can happen, maybe the bit was set anyway at an earlier stage. The tests run fine.

BUG=
TEST=rtp_rtcp_unittests, vie_auto_test, voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/1022011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3382 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
phoglund@webrtc.org
2013-01-17 16:10:45 +00:00
parent 20ed36dada
commit efae5d5901
10 changed files with 454 additions and 313 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
webrtc/modules/rtp_rtcp/source/rtp_receiver_video.h
View File

@ -23,12 +23,12 @@ class CriticalSectionWrapper;
class ModuleRtpRtcpImpl;
class ReceiverFEC;
class RTPReceiver;
class RTPPayloadRegistry;
class RTPReceiverVideo : public RTPReceiverStrategy {
public:
// TODO(phoglund): Get rid of dependency on "parent".
RTPReceiverVideo(const WebRtc_Word32 id,
RTPReceiver* parent,
const RTPPayloadRegistry* rtp_payload_registry,
RtpData* data_callback,
ModuleRtpRtcpImpl* owner);
@ -40,7 +40,8 @@ class RTPReceiverVideo : public RTPReceiverStrategy {
const bool is_red,
const WebRtc_UWord8* packet,
const WebRtc_UWord16 packet_length,
const WebRtc_Word64 timestamp);
const WebRtc_Word64 timestamp,
const bool is_first_packet);
WebRtc_Word32 GetFrequencyHz() const;
@ -85,7 +86,8 @@ class RTPReceiverVideo : public RTPReceiverStrategy {
WebRtcRTPHeader* rtpHeader,
const WebRtc_UWord8* payloadData,
const WebRtc_UWord16 payloadDataLength,
const RtpVideoCodecTypes videoType);
const RtpVideoCodecTypes videoType,
const bool isFirstPacket);
WebRtc_Word32 ReceiveGenericCodec(WebRtcRTPHeader *rtpHeader,
const WebRtc_UWord8* payloadData,
@ -107,10 +109,11 @@ class RTPReceiverVideo : public RTPReceiverStrategy {
const bool isRED,
const WebRtc_UWord8* incomingRtpPacket,
const WebRtc_UWord16 incomingRtpPacketSize,
const WebRtc_Word64 nowMS);
const WebRtc_Word64 nowMS,
const bool isFirstPacket);
WebRtc_Word32 _id;
RTPReceiver* _parent;
const RTPPayloadRegistry* _rtpRtpPayloadRegistry;
CriticalSectionWrapper* _criticalSectionReceiverVideo;