From f11b46bc4b71c0c7df4cf8db38c807167ee9bfcd Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Wed, 13 Nov 2019 16:49:35 +0000 Subject: [PATCH] Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."" This reverts commit f181137b05e4b899fa3f15afafc4f27e683d83cc. Reason for revert: This CL was just needed in order to have a WebRTC commit to pin in Chromium to test the component build (this CL enables symbol exports). Original change's description: > Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." > > This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed > > I will revert this reland as soon as it lands because I just need > to have a WebRTC commit to pin in Chromium in order to test the > component build (this CL enables symbol exports). > > Original change's description: > > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > > > In order to land the component build support in Chromium, it is > > easier to turn on symbols export every time that is_component_build=true > > instead of setting rtc_enable_symbol_export=is_component_build in > > Chromium (since is_component_build is not available in .gn). > > > > rtc_enable_symbol_export is still kept in the mix in order to turn > > on symbol exports in any case a shared library will be added to the > > WebRTC build. > > > > Bug: webrtc:9419 > > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > > Reviewed-by: Karl Wiberg > > Commit-Queue: Mirko Bonadei > > Cr-Commit-Position: refs/heads/master@{#29540} > > No-Try: True > TBR: kwiberg@webrtc.org > Bug: webrtc:9419 > Change-Id: I8582242910bb3633b7a4675ff261b5a6a0b6954e > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159712 > Reviewed-by: Mirko Bonadei > Commit-Queue: Mirko Bonadei > Cr-Commit-Position: refs/heads/master@{#29795} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org Change-Id: I6bbe0288d07e49c8a4c808c758ecb6e2ddfa2aa8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9419 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159713 Reviewed-by: Mirko Bonadei Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#29796} --- BUILD.gn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILD.gn b/BUILD.gn index 98ff6a039d..73569c5a09 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -111,7 +111,7 @@ config("common_inherited_config") { cflags = [] ldflags = [] - if (rtc_enable_symbol_export || is_component_build) { + if (rtc_enable_symbol_export) { defines = [ "WEBRTC_ENABLE_SYMBOL_EXPORT" ] }