Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."
This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed I will revert this reland as soon as it lands because I just need to have a WebRTC commit to pin in Chromium in order to test the component build (this CL enables symbol exports). Original change's description: > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > In order to land the component build support in Chromium, it is > easier to turn on symbols export every time that is_component_build=true > instead of setting rtc_enable_symbol_export=is_component_build in > Chromium (since is_component_build is not available in .gn). > > rtc_enable_symbol_export is still kept in the mix in order to turn > on symbol exports in any case a shared library will be added to the > WebRTC build. > > Bug: webrtc:9419 > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29540} No-Try: True TBR: kwiberg@webrtc.org Bug: webrtc:9419 Change-Id: I8582242910bb3633b7a4675ff261b5a6a0b6954e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159712 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29795}
This commit is contained in:

committed by
Commit Bot

parent
1b66890a45
commit
f181137b05
2
BUILD.gn
2
BUILD.gn
@ -111,7 +111,7 @@ config("common_inherited_config") {
|
|||||||
cflags = []
|
cflags = []
|
||||||
ldflags = []
|
ldflags = []
|
||||||
|
|
||||||
if (rtc_enable_symbol_export) {
|
if (rtc_enable_symbol_export || is_component_build) {
|
||||||
defines = [ "WEBRTC_ENABLE_SYMBOL_EXPORT" ]
|
defines = [ "WEBRTC_ENABLE_SYMBOL_EXPORT" ]
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user