Add task queue to RtpRtcpInterface::Configuration.
Let ModuleRtpRtcpImpl2 use the configured value instead of TaskQueueBase::Current(). Intention is to allow construction of RtpRtcpImpl2 on any thread. If a task queue is provided (required for periodic rtt updates), the destruction of the object must be done on that same task queue. Also, delete ModuleRtpRtcpImpl2::Create, callers updated to use std::make_unique. Bug: None Change-Id: I412b7b1e1ce24722ffd23d16aa6c48a7214c9bcd Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/199968 Reviewed-by: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32949}
This commit is contained in:
@ -92,7 +92,7 @@ class RtcpSenderTest : public ::testing::Test {
|
||||
receive_statistics_(ReceiveStatistics::Create(&clock_)),
|
||||
retransmission_rate_limiter_(&clock_, 1000) {
|
||||
RtpRtcpInterface::Configuration configuration = GetDefaultConfig();
|
||||
rtp_rtcp_impl_.reset(new ModuleRtpRtcpImpl2(configuration));
|
||||
rtp_rtcp_impl_ = std::make_unique<ModuleRtpRtcpImpl2>(configuration);
|
||||
}
|
||||
|
||||
RtpRtcpInterface::Configuration GetDefaultConfig() {
|
||||
|
||||
Reference in New Issue
Block a user