zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cleanup of feedback observer interface

Browse Source 
Removes all unused features, reducing the exposed interface surface.
This makes refactoring and maintenance simpler as we can change
TransportFeedbackAdapter without making corresponding changes
to RtpVideoSender.

Bug: webrtc:9883
Change-Id: If372a868e0765e94df52b4de52d3bb619ce11471
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156943
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29649}
This commit is contained in:
Sebastian Jansson
2019-10-29 17:18:51 +01:00
committed by Commit Bot
parent 470b2d5144
commit f298855981
12 changed files with 142 additions and 112 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
call/rtp_transport_controller_send_interface.h
View File

@ -44,7 +44,6 @@ class TargetTransferRateObserver;
class Transport;
class Module;
class PacedSender;
class PacketFeedbackObserver;
class PacketRouter;
class RtpVideoSenderInterface;
class RateLimiter;
@ -52,7 +51,6 @@ class RtcpBandwidthObserver;
class RtpPacketSender;
class SendDelayStats;
class SendStatisticsProxy;
class TransportFeedbackObserver;
struct RtpSenderObservers {
RtcpRttStats* rtcp_rtt_stats;
@ -129,10 +127,12 @@ class RtpTransportControllerSendInterface {
virtual void SetPacingFactor(float pacing_factor) = 0;
virtual void SetQueueTimeLimit(int limit_ms) = 0;
virtual StreamFeedbackProvider* GetStreamFeedbackProvider() = 0;
// DEPRECATED, use GetStreamFeedbackProvider instead.
virtual void RegisterPacketFeedbackObserver(
PacketFeedbackObserver* observer) = 0;
PacketFeedbackObserver* observer) {}
virtual void DeRegisterPacketFeedbackObserver(
PacketFeedbackObserver* observer) = 0;
PacketFeedbackObserver* observer) {}
virtual void RegisterTargetTransferRateObserver(
TargetTransferRateObserver* observer) = 0;
virtual void OnNetworkRouteChanged(