zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Stay writable after partial socket writes.

Browse Source 
This CL fixes an issue where the "writable" flag didn't stay set after
::send or ::sendto only sent a partial buffer.

Also SocketTest::TcpInternal has been updated to use rtc::Buffer instead
of manually allocating data.

BUG=webrtc:4898

Review URL: https://codereview.webrtc.org/1616153007

Cr-Commit-Position: refs/heads/master@{#11480}
This commit is contained in:
jbauch
2016-02-03 16:45:32 -08:00
committed by Commit bot
parent 14d024d882
commit f2a2bf4ae4
5 changed files with 194 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
webrtc/base/socket_unittest.h
View File

@ -62,6 +62,10 @@ class SocketTest : public testing::Test {
const IPAddress kIPv4Loopback;
const IPAddress kIPv6Loopback;
protected:
void TcpInternal(const IPAddress& loopback, size_t data_size,
ssize_t max_send_size);
private:
void ConnectInternal(const IPAddress& loopback);
void ConnectWithDnsLookupInternal(const IPAddress& loopback,
@ -76,7 +80,6 @@ class SocketTest : public testing::Test {
void ServerCloseInternal(const IPAddress& loopback);
void CloseInClosedCallbackInternal(const IPAddress& loopback);
void SocketServerWaitInternal(const IPAddress& loopback);
void TcpInternal(const IPAddress& loopback);
void SingleFlowControlCallbackInternal(const IPAddress& loopback);
void UdpInternal(const IPAddress& loopback);
void UdpReadyToSend(const IPAddress& loopback);