zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Deprecate PeerConnectionFactory::CreatePeerConnection

Browse Source 
Applications should use CreatePeerConnectionOrError instead.

Moved fallback implementations of CreatePeerConnection into the
api/peer_connection_interface.h file, so that we do not have to
declare these methods in the proxy.

Bug: webrtc:12238
Change-Id: I70c56336641c2a108b68446ae41f43409277a584
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/217762
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33964}
This commit is contained in:
Harald Alvestrand
2021-05-09 14:58:57 +00:00
committed by WebRTC LUCI CQ
parent 91c48f3a16
commit f33f7a2ada
18 changed files with 97 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
sdk/android/src/jni/pc/peer_connection_factory.cc
View File

@ -471,14 +471,14 @@ static jlong JNI_PeerConnectionFactory_CreatePeerConnection(
jni, j_sslCertificateVerifier);
}
rtc::scoped_refptr<PeerConnectionInterface> pc =
PeerConnectionFactoryFromJava(factory)->CreatePeerConnection(
auto result =
PeerConnectionFactoryFromJava(factory)->CreatePeerConnectionOrError(
rtc_config, std::move(peer_connection_dependencies));
if (!pc)
if (!result.ok())
return 0;
return jlongFromPointer(
new OwnedPeerConnection(pc, std::move(observer), std::move(constraints)));
return jlongFromPointer(new OwnedPeerConnection(
result.MoveValue(), std::move(observer), std::move(constraints)));
}
static jlong JNI_PeerConnectionFactory_CreateVideoSource(