From f47c2ab889d968888979fa31bd8229543c76967d Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Tue, 12 Nov 2019 20:36:05 +0100 Subject: [PATCH] RTC_EXPORT webrtc::RTCNonStandardStatsMember. Since webrtc::RTCNonStandardStatsMember extends some explicit template initializations, its symbols need to be exported as well. Example of an lld-link error: https://ci.chromium.org/p/chromium/builders/try/win_chromium_compile_dbg_ng/435974 Bug: webrtc:9419 Change-Id: I48bd484b821b17a214e0180e78ba34c38e247947 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159693 Reviewed-by: Steve Anton Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#29780} --- api/stats/rtc_stats.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/stats/rtc_stats.h b/api/stats/rtc_stats.h index e9d11241ce..044fadab51 100644 --- a/api/stats/rtc_stats.h +++ b/api/stats/rtc_stats.h @@ -387,7 +387,7 @@ WEBRTC_DECLARE_RTCSTATSMEMBER(std::vector); // Using inheritance just so that it's obvious from the member's declaration // whether it's standardized or not. template -class RTCNonStandardStatsMember : public RTCStatsMember { +class RTC_EXPORT RTCNonStandardStatsMember : public RTCStatsMember { public: explicit RTCNonStandardStatsMember(const char* name) : RTCStatsMember(name) {}