zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PyLint fixes for tools-webrtc and webrtc/tools

Browse Source 
Fix a lot of errors before bringing in the new config in
https://codereview.webrtc.org/2737963003/

BUG=webrtc:7303
NOTRY=True

Review-Url: https://codereview.webrtc.org/2736233003
Cr-Commit-Position: refs/heads/master@{#17137}
This commit is contained in:
kjellander
2017-03-09 02:26:46 -08:00
committed by Commit bot
parent 735da3ad38
commit f5318e1f39
15 changed files with 142 additions and 145 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
PRESUBMIT.py
View File

@ -116,7 +116,7 @@ def _VerifyNativeApiHeadersListIsValid(input_api, output_api):
non_existing_paths)]
return []
api_change_msg = """
API_CHANGE_MSG = """
You seem to be changing native API header files. Please make sure that you:
1. Make compatible changes that don't break existing clients. Usually
this is done by keeping the existing method signatures unchanged.
@ -145,7 +145,7 @@ def _CheckNativeApiHeaderChanges(input_api, output_api):
files.append(f)
if files:
return [output_api.PresubmitNotifyResult(api_change_msg, files)]
return [output_api.PresubmitNotifyResult(API_CHANGE_MSG, files)]
return []
@ -190,7 +190,7 @@ def _CheckNoPragmaOnce(input_api, output_api):
return []
def _CheckNoFRIEND_TEST(input_api, output_api):
def _CheckNoFRIEND_TEST(input_api, output_api): # pylint: disable=invalid-name
"""Make sure that gtest's FRIEND_TEST() macro is not used, the
FRIEND_TEST_ALL_PREFIXES() macro from testsupport/gtest_prod_util.h should be
used instead since that allows for FLAKY_, FAILS_ and DISABLED_ prefixes."""
@ -452,13 +452,13 @@ def _CheckJSONParseErrors(input_api, output_api):
def _RunPythonTests(input_api, output_api):
def join(*args):
def Join(*args):
return input_api.os_path.join(input_api.PresubmitLocalPath(), *args)
test_directories = [
join('webrtc', 'tools', 'py_event_log_analyzer')
Join('webrtc', 'tools', 'py_event_log_analyzer')
] + [
root for root, _, files in os.walk(join('tools-webrtc'))
root for root, _, files in os.walk(Join('tools-webrtc'))
if any(f.endswith('_test.py') for f in files)
]