zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SSLCertificate::GetChain: Return scoped_ptr

Browse Source 
Instead of using a raw pointer output parameter. This is a good idea
in general, but will also be very convenient when scoped_ptr is gone,
since unique_ptr doesn't have an .accept() method.

BUG=webrtc:5520

Review URL: https://codereview.webrtc.org/1799233002

Cr-Commit-Position: refs/heads/master@{#12004}
This commit is contained in:
kwiberg
2016-03-15 12:53:24 -07:00
committed by Commit bot
parent 6021fe2b1e
commit f5d4786080
6 changed files with 15 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
webrtc/base/sslstreamadapter_unittest.cc
View File

@ -1056,8 +1056,7 @@ TEST_F(SSLStreamAdapterTestDTLSFromPEMStrings, TestDTLSGetPeerCertificate) {
ASSERT_NE(kCERT_PEM, client_peer_string);
// It must not have a chain, because the test certs are self-signed.
rtc::SSLCertChain* client_peer_chain;
ASSERT_FALSE(client_peer_cert->GetChain(&client_peer_chain));
ASSERT_FALSE(client_peer_cert->GetChain());
// The server should have a peer certificate after the handshake.
ASSERT_TRUE(GetPeerCertificate(false, server_peer_cert.accept()));
@ -1067,8 +1066,7 @@ TEST_F(SSLStreamAdapterTestDTLSFromPEMStrings, TestDTLSGetPeerCertificate) {
ASSERT_EQ(kCERT_PEM, server_peer_cert->ToPEMString());
// It must not have a chain, because the test certs are self-signed.
rtc::SSLCertChain* server_peer_chain;
ASSERT_FALSE(server_peer_cert->GetChain(&server_peer_chain));
ASSERT_FALSE(server_peer_cert->GetChain());
}
// Test getting the used DTLS ciphers.