zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Populate y-axis categorical labels in event log visualizer.

Browse Source 
Bug: webrtc:10623
Change-Id: Ica2f6485e44ffa6331e88d7980c294d93bed1539
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145410
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28665}
This commit is contained in:
Bjorn Terelius
2019-07-24 15:46:39 +02:00
committed by Commit Bot
parent 9973933d2e
commit f640b87f1c
1 changed files with 41 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
rtc_tools/event_log_visualizer/analyzer.cc
View File

@ -567,6 +567,14 @@ void EventLogAnalyzer::CreateRtcpTypeGraph(PacketDirection direction,
"Time (s)", kLeftMargin, kRightMargin); "Time (s)", kLeftMargin, kRightMargin);
plot->SetSuggestedYAxis(0, 1, "RTCP type", kBottomMargin, kTopMargin); plot->SetSuggestedYAxis(0, 1, "RTCP type", kBottomMargin, kTopMargin);
plot->SetTitle(GetDirectionAsString(direction) + " RTCP packets"); plot->SetTitle(GetDirectionAsString(direction) + " RTCP packets");
plot->SetYAxisTickLabels({{1, "TWCC"},
{2, "RR"},
{3, "SR"},
{4, "XR"},
{5, "NACK"},
{6, "REMB"},
{7, "FIR"},
{8, "PLI"}});
} }
template <typename IterableType> template <typename IterableType>
@ -2116,9 +2124,15 @@ void EventLogAnalyzer::CreateIceCandidatePairConfigGraph(Plot* plot) {
plot->SetXAxis(config_.CallBeginTimeSec(), config_.CallEndTimeSec(), plot->SetXAxis(config_.CallBeginTimeSec(), config_.CallEndTimeSec(),
"Time (s)", kLeftMargin, kRightMargin); "Time (s)", kLeftMargin, kRightMargin);
plot->SetSuggestedYAxis(0, 3, "Numeric Config Type", kBottomMargin, plot->SetSuggestedYAxis(0, 3, "Config Type", kBottomMargin, kTopMargin);
kTopMargin);
plot->SetTitle("[IceEventLog] ICE candidate pair configs"); plot->SetTitle("[IceEventLog] ICE candidate pair configs");
plot->SetYAxisTickLabels(
{{static_cast<float>(IceCandidatePairConfigType::kAdded), "ADDED"},
{static_cast<float>(IceCandidatePairConfigType::kUpdated), "UPDATED"},
{static_cast<float>(IceCandidatePairConfigType::kDestroyed),
"DESTROYED"},
{static_cast<float>(IceCandidatePairConfigType::kSelected),
"SELECTED"}});
} }
std::string EventLogAnalyzer::GetCandidatePairLogDescriptionFromId( std::string EventLogAnalyzer::GetCandidatePairLogDescriptionFromId(
@ -2142,6 +2156,8 @@ std::string EventLogAnalyzer::GetCandidatePairLogDescriptionFromId(
} }
void EventLogAnalyzer::CreateIceConnectivityCheckGraph(Plot* plot) { void EventLogAnalyzer::CreateIceConnectivityCheckGraph(Plot* plot) {
constexpr int kEventTypeOffset =
static_cast<int>(IceCandidatePairConfigType::kNumValues);
std::map<uint32_t, TimeSeries> checks_by_cp_id; std::map<uint32_t, TimeSeries> checks_by_cp_id;
for (const auto& event : parsed_log_.ice_candidate_pair_events()) { for (const auto& event : parsed_log_.ice_candidate_pair_events()) {
if (checks_by_cp_id.find(event.candidate_pair_id) == if (checks_by_cp_id.find(event.candidate_pair_id) ==
@ -2152,9 +2168,7 @@ void EventLogAnalyzer::CreateIceConnectivityCheckGraph(Plot* plot) {
LineStyle::kNone, PointStyle::kHighlight); LineStyle::kNone, PointStyle::kHighlight);
} }
float x = config_.GetCallTimeSec(event.log_time_us()); float x = config_.GetCallTimeSec(event.log_time_us());
constexpr int kIceCandidatePairEventTypeOffset = float y = static_cast<float>(event.type) + kEventTypeOffset;
static_cast<int>(IceCandidatePairConfigType::kNumValues);
float y = static_cast<float>(event.type) + kIceCandidatePairEventTypeOffset;
checks_by_cp_id[event.candidate_pair_id].points.emplace_back(x, y); checks_by_cp_id[event.candidate_pair_id].points.emplace_back(x, y);
} }
@ -2165,9 +2179,23 @@ void EventLogAnalyzer::CreateIceConnectivityCheckGraph(Plot* plot) {
plot->SetXAxis(config_.CallBeginTimeSec(), config_.CallEndTimeSec(), plot->SetXAxis(config_.CallBeginTimeSec(), config_.CallEndTimeSec(),
"Time (s)", kLeftMargin, kRightMargin); "Time (s)", kLeftMargin, kRightMargin);
plot->SetSuggestedYAxis(0, 4, "Numeric Connectivity State", kBottomMargin, plot->SetSuggestedYAxis(0, 4, "Connectivity State", kBottomMargin,
kTopMargin); kTopMargin);
plot->SetTitle("[IceEventLog] ICE connectivity checks"); plot->SetTitle("[IceEventLog] ICE connectivity checks");
plot->SetYAxisTickLabels(
{{static_cast<float>(IceCandidatePairEventType::kCheckSent) +
kEventTypeOffset,
"CHECK SENT"},
{static_cast<float>(IceCandidatePairEventType::kCheckReceived) +
kEventTypeOffset,
"CHECK RECEIVED"},
{static_cast<float>(IceCandidatePairEventType::kCheckResponseSent) +
kEventTypeOffset,
"RESPONSE SENT"},
{static_cast<float>(IceCandidatePairEventType::kCheckResponseReceived) +
kEventTypeOffset,
"RESPONSE RECEIVED"}});
} }
void EventLogAnalyzer::CreateDtlsTransportStateGraph(Plot* plot) { void EventLogAnalyzer::CreateDtlsTransportStateGraph(Plot* plot) {
@ -2182,8 +2210,14 @@ void EventLogAnalyzer::CreateDtlsTransportStateGraph(Plot* plot) {
plot->SetXAxis(config_.CallBeginTimeSec(), config_.CallEndTimeSec(), plot->SetXAxis(config_.CallBeginTimeSec(), config_.CallEndTimeSec(),
"Time (s)", kLeftMargin, kRightMargin); "Time (s)", kLeftMargin, kRightMargin);
plot->SetSuggestedYAxis(0, static_cast<float>(DtlsTransportState::kNumValues), plot->SetSuggestedYAxis(0, static_cast<float>(DtlsTransportState::kNumValues),
"Numeric Transport State", kBottomMargin, kTopMargin); "Transport State", kBottomMargin, kTopMargin);
plot->SetTitle("DTLS Transport State"); plot->SetTitle("DTLS Transport State");
plot->SetYAxisTickLabels(
{{static_cast<float>(DtlsTransportState::kNew), "NEW"},
{static_cast<float>(DtlsTransportState::kConnecting), "CONNECTING"},
{static_cast<float>(DtlsTransportState::kConnected), "CONNECTED"},
{static_cast<float>(DtlsTransportState::kClosed), "CLOSED"},
{static_cast<float>(DtlsTransportState::kFailed), "FAILED"}});
} }
void EventLogAnalyzer::CreateDtlsWritableStateGraph(Plot* plot) { void EventLogAnalyzer::CreateDtlsWritableStateGraph(Plot* plot) {