zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove WebRTC-LowLatencyRenderer field trial

Browse Source 
There is no active use of it, and the fields are enabled by default in
the uses of it.

Change-Id: Ibfdb3f1befca886cb4b2f4b2ae4d6235aafafe3d
Fixed: webrtc:13998
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256262
Reviewed-by: Johannes Kron <kron@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Evan Shrubsole <eshr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36655}
This commit is contained in:
Evan Shrubsole
2022-04-26 11:10:21 +02:00
committed by WebRTC LUCI CQ
parent a0ee64c57e
commit f6adc647ba
6 changed files with 17 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
modules/video_coding/timing.cc
View File

@ -22,6 +22,8 @@ namespace {
// Default pacing that is used for the low-latency renderer path.
constexpr TimeDelta kZeroPlayoutDelayDefaultMinPacing = TimeDelta::Millis(8);
constexpr TimeDelta kLowLatencyRendererMaxPlayoutDelay = TimeDelta::Millis(500);
} // namespace
VCMTiming::VCMTiming(Clock* clock, const FieldTrialsView& field_trials)
@ -36,12 +38,9 @@ VCMTiming::VCMTiming(Clock* clock, const FieldTrialsView& field_trials)
current_delay_(TimeDelta::Zero()),
prev_frame_timestamp_(0),
num_decoded_frames_(0),
low_latency_renderer_enabled_("enabled", true),
zero_playout_delay_min_pacing_("min_pacing",
kZeroPlayoutDelayDefaultMinPacing),
last_decode_scheduled_(Timestamp::Zero()) {
ParseFieldTrial({&low_latency_renderer_enabled_},
field_trials.Lookup("WebRTC-LowLatencyRenderer"));
ParseFieldTrial({&zero_playout_delay_min_pacing_},
field_trials.Lookup("WebRTC-ZeroPlayoutDelay"));
}
@ -165,12 +164,9 @@ void VCMTiming::SetLastDecodeScheduledTimestamp(
Timestamp VCMTiming::RenderTimeInternal(uint32_t frame_timestamp,
Timestamp now) const {
constexpr TimeDelta kLowLatencyRendererMaxPlayoutDelay =
TimeDelta::Millis(500);
if (min_playout_delay_.IsZero() &&
(max_playout_delay_.IsZero() ||
(low_latency_renderer_enabled_ &&
max_playout_delay_ <= kLowLatencyRendererMaxPlayoutDelay))) {
max_playout_delay_ <= kLowLatencyRendererMaxPlayoutDelay)) {
// Render as soon as possible or with low-latency renderer algorithm.
return Timestamp::Zero();
}