From f70bc5eeff3f7ff4160c49015fe1df369d24a2ca Mon Sep 17 00:00:00 2001 From: Sebastian Jansson Date: Thu, 2 Aug 2018 17:31:29 +0200 Subject: [PATCH] Removes pause check from RoundRobinPacketQueue. This CL removes a check in RoundRobinPacketQueue::FinalizePop. This check will trigger if a the pause state is changed in PacedSender while a packet is sent. This is a rare occurrence but would yield flaky behavior. The check should not be required for the code to function since the paused state is not read in FinalizePop other than for this check. Bug: webrtc:9586 Change-Id: Ib9476168eb637dc2f9710d0592bed92c4b03dacb Reviewed-on: https://webrtc-review.googlesource.com/92090 Reviewed-by: Philip Eliasson Commit-Queue: Sebastian Jansson Cr-Commit-Position: refs/heads/master@{#24197} --- modules/pacing/round_robin_packet_queue.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/modules/pacing/round_robin_packet_queue.cc b/modules/pacing/round_robin_packet_queue.cc index 2a16b4b50b..a7cb8befda 100644 --- a/modules/pacing/round_robin_packet_queue.cc +++ b/modules/pacing/round_robin_packet_queue.cc @@ -88,7 +88,6 @@ void RoundRobinPacketQueue::CancelPop(const Packet& packet) { } void RoundRobinPacketQueue::FinalizePop(const Packet& packet) { - RTC_CHECK(!paused_); if (!Empty()) { RTC_CHECK(pop_packet_ && pop_stream_); Stream* stream = *pop_stream_;