zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use AggressiveConfiguration as the default configuration in IOS

Browse Source 
R=haysc@webrtc.org, pthatcher@webrtc.org, tkchin@webrtc.org

Review URL: https://codereview.webrtc.org/2297663004 .

Cr-Commit-Position: refs/heads/master@{#14030}
This commit is contained in:
Honghai Zhang
2016-09-01 15:34:01 -07:00
parent affcac4d22
commit f7ddc06a43
3 changed files with 22 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
webrtc/api/peerconnectioninterface.h
View File

@ -227,6 +227,15 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
GATHER_CONTINUALLY
};
enum class RTCConfigurationType {
// A configuration that is safer to use, despite not having the best
// performance. Currently this is the default configuration.
kSafe,
// An aggressive configuration that has better performance, although it
// may be riskier and may need extra support in the application.
kAggressive
};
// TODO(hbos): Change into class with private data and public getters.
// TODO(nisse): In particular, accessing fields directly from an
// application is brittle, since the organization mirrors the
@ -240,16 +249,11 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
// methods for all settings which are of interest to applications,
// Chrome in particular.
// A configuration that is safer to use, despite it may not have the best
// performance.
static RTCConfiguration SafeConfiguration() { return RTCConfiguration(); }
// An aggressive configuration that has better performance, although it
// may be riskier and may need extra support in the application.
static RTCConfiguration AggressiveConfiguration() {
RTCConfiguration config;
config.redetermine_role_on_ice_restart = false;
return config;
RTCConfiguration() = default;
RTCConfiguration(RTCConfigurationType type) {
if (type == RTCConfigurationType::kAggressive) {
redetermine_role_on_ice_restart = false;
}
}
bool dscp() { return media_config.enable_dscp; }