zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix "control reaches end of non-void function" warnings

Browse Source 
"warning: control reaches end of non-void function [-Wreturn-type]"
Reported by gcc (8.3)

In all the reported cases, the end of function is never actually
reached. Add RTC_CHECK(false) to ensure the compiler is aware that
this path is a dead-end.

Bug: webrtc:12008
Change-Id: I7f816fde3d1897ed2774057c7e05da66e1895e60
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/189784
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Fabien VALLÉE <fabien.vallee@netgem.com>
Cr-Commit-Position: refs/heads/master@{#32503}
This commit is contained in:
Fabien Vallée
2020-10-22 10:08:50 +02:00
committed by Commit Bot
parent aa83cc7fda
commit f8b5bfeaf2
23 changed files with 38 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
modules/audio_processing/include/audio_processing.cc
View File

@ -31,6 +31,7 @@ std::string NoiseSuppressionLevelToString(
case AudioProcessing::Config::NoiseSuppression::Level::kVeryHigh:
return "VeryHigh";
}
RTC_CHECK(false);
}
std::string GainController1ModeToString(const Agc1Config::Mode& mode) {
@ -42,6 +43,7 @@ std::string GainController1ModeToString(const Agc1Config::Mode& mode) {
case Agc1Config::Mode::kFixedDigital:
return "FixedDigital";
}
RTC_CHECK(false);
}
std::string GainController2LevelEstimatorToString(
@ -52,6 +54,7 @@ std::string GainController2LevelEstimatorToString(
case Agc2Config::LevelEstimator::kPeak:
return "Peak";
}
RTC_CHECK(false);
}
int GetDefaultMaxInternalRate() {