zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use range-based-for instead of std::for_each and std::mem_fun

Browse Source 
std::mem_fun is deprecated in C++11, and removed in C++17. Using C++17
option for building libwebrtc causes build failure. This is found during
upgrading WebKit tree from C++14 to C++17.
This patch replaces std::for_each and std::mem_fun with range-based-for.
We also merge loops for streams_ into one.

Bug: webrtc:9277
Change-Id: I44a7e44ea21fc33ffa9a586ddfea570f97dfacb6
Reviewed-on: https://webrtc-review.googlesource.com/77280
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23285}
This commit is contained in:
Yusuke Suzuki
2018-05-17 22:01:13 +09:00
committed by Commit Bot
parent c475ac14a9
commit f8d8d6d00c
2 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
AUTHORS
View File

@ -61,6 +61,7 @@ Hans Knoechel <hans@hans-knoechel.de>
Korniltsev Anatoly <korniltsev.anatoly@gmail.com> Korniltsev Anatoly <korniltsev.anatoly@gmail.com>
Todd Wong <todd.wong.ndq@gmail.com> Todd Wong <todd.wong.ndq@gmail.com>
Maxim Pavlov <pavllovmax@gmail.com> Maxim Pavlov <pavllovmax@gmail.com>
Yusuke Suzuki <utatane.tea@gmail.com>
&yet LLC <*@andyet.com> &yet LLC <*@andyet.com>
Agora IO <*@agora.io> Agora IO <*@agora.io>

10
call/bitrate_estimator_tests.cc
View File

@ -136,13 +136,11 @@ class BitrateEstimatorTest : public test::CallTest {
virtual void TearDown() { virtual void TearDown() {
task_queue_.SendTask([this]() { task_queue_.SendTask([this]() {
std::for_each(streams_.begin(), streams_.end(), for (auto* stream : streams_) {
std::mem_fun(&Stream::StopSending)); stream->StopSending();
delete stream;
while (!streams_.empty()) {
delete streams_.back();
streams_.pop_back();
} }
streams_.clear();
send_transport_.reset(); send_transport_.reset();
receive_transport_.reset(); receive_transport_.reset();