zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reland "Remove legacy delay manger field trial and update default config."

Browse Source 
This is a reland of 93849d4b2a976b0a46059d6f74d9efd8f12eab92

Original change's description:
> Remove legacy delay manger field trial and update default config.
>
> Bug: webrtc:10333
> Change-Id: I20e55d8d111d93657d1afe556fe3a325337c074c
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232820
> Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
> Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#35321}

Bug: webrtc:10333
Change-Id: I9b3c732309d32640d15c372a4dde37d5d44c95d1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237502
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35325}
This commit is contained in:
Jakob Ivarsson
2021-11-09 12:58:45 +01:00
committed by WebRTC LUCI CQ
parent 46814941f2
commit fa68ac0c4e
11 changed files with 149 additions and 298 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
modules/audio_coding/neteq/delay_manager.h
View File

@ -23,7 +23,6 @@
#include "modules/audio_coding/neteq/reorder_optimizer.h"
#include "modules/audio_coding/neteq/underrun_optimizer.h"
#include "rtc_base/constructor_magic.h"
#include "rtc_base/experiments/struct_parameters_parser.h"
namespace webrtc {
@ -34,10 +33,10 @@ class DelayManager {
void Log();
// Options that can be configured via field trial.
double quantile = 0.97;
double forget_factor = 0.9993;
double quantile = 0.95;
double forget_factor = 0.983;
absl::optional<double> start_forget_weight = 2;
absl::optional<int> resample_interval_ms;
absl::optional<int> resample_interval_ms = 500;
int max_history_ms = 2000;
bool use_reorder_optimizer = true;
@ -47,12 +46,6 @@ class DelayManager {
// Options that are externally populated.
int max_packets_in_buffer = 200;
int base_minimum_delay_ms = 0;
private:
std::unique_ptr<StructParametersParser> Parser();
// TODO(jakobi): remove legacy field trial.
void MaybeUpdateFromLegacyFieldTrial();
};
DelayManager(const Config& config, const TickTimer* tick_timer);