zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Provide a default no-op implementation of RegisterUMAObserver in

Browse Source 
PeerConnectionInterface.

This allows the implementations of PeerConnectionInterface to deprecate
this method.

Bug: None
Change-Id: I54b56206ebac2486f112e09137c9def225683297
Reviewed-on: https://webrtc-review.googlesource.com/89261
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24011}
This commit is contained in:
Qingsi Wang
2018-07-17 16:27:44 -07:00
committed by Qingsi Wang
parent 0f5400acfa
commit fad70c05ca
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
api/peerconnectioninterface.h
View File

@ -960,7 +960,10 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
// this method takes a reference. RegisterUMAObserver(nullptr) will release // this method takes a reference. RegisterUMAObserver(nullptr) will release
// the reference. // the reference.
// TODO(deadbeef): Take argument as scoped_refptr? // TODO(deadbeef): Take argument as scoped_refptr?
virtual void RegisterUMAObserver(UMAObserver* observer) = 0; //
// This method is soon to be deprecated. This no-op default implementation
// allows the implementations of the interface to remove this method.
virtual void RegisterUMAObserver(UMAObserver* observer) {}
// 0 <= min <= current <= max should hold for set parameters. // 0 <= min <= current <= max should hold for set parameters.
struct BitrateParameters { struct BitrateParameters {