From fca30875b66c26a7f1d380f2d58e3e6297ab487d Mon Sep 17 00:00:00 2001 From: Mirta Dvornicic Date: Wed, 15 Jul 2020 14:10:31 +0200 Subject: [PATCH] Do not use internal source in video send stream tests. Unless testing a behavior specific to video encoders with internal source. Bug: None Change-Id: Ia42177f2a0b7e658060208444870a7466c6779dd Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179362 Reviewed-by: Niels Moller Reviewed-by: Ilya Nikolaevskiy Commit-Queue: Mirta Dvornicic Cr-Commit-Position: refs/heads/master@{#31740} --- video/video_send_stream_tests.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/video/video_send_stream_tests.cc b/video/video_send_stream_tests.cc index efbcef7278..64a1a55710 100644 --- a/video/video_send_stream_tests.cc +++ b/video/video_send_stream_tests.cc @@ -2280,13 +2280,15 @@ TEST_F(VideoSendStreamTest, CanReconfigureToUseStartBitrateAbovePreviousMax) { StartBitrateObserver encoder; test::VideoEncoderProxyFactory encoder_factory(&encoder); - // Since this test does not use a capturer, set |internal_source| = true. - // Encoder configuration is otherwise updated on the next video frame. - encoder_factory.SetHasInternalSource(true); GetVideoSendConfig()->encoder_settings.encoder_factory = &encoder_factory; CreateVideoStreams(); + // Start capturing and encoding frames to force encoder reconfiguration. + CreateFrameGeneratorCapturer(kDefaultFramerate, kDefaultWidth, + kDefaultHeight); + frame_generator_capturer_->Start(); + EXPECT_TRUE(encoder.WaitForStartBitrate()); EXPECT_EQ(GetVideoEncoderConfig()->max_bitrate_bps / 1000, encoder.GetStartBitrateKbps());