zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Use backticks not vertical bars to denote variables in comments for /pc"

Browse Source 
This reverts commit 37ee0f5e594dd772ec6d620b5e5ea8a751b684f0.

Reason for revert: Revert in order to be able to revert https://webrtc-review.googlesource.com/c/src/+/225642

Original change's description:
> Use backticks not vertical bars to denote variables in comments for /pc
>
> Bug: webrtc:12338
> Change-Id: I88cf10afa5fc810b95d2a585ab2e895dcc163b63
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226953
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Commit-Queue: Artem Titov <titovartem@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#34575}

TBR=hta@webrtc.org,titovartem@webrtc.org,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I5eddd3a14e1f664bf831e5c294fbc4de5f6a88af
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:12338
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227082
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34577}
This commit is contained in:
Björn Terelius
2021-07-27 22:09:55 +00:00
committed by WebRTC LUCI CQ
parent fc5506e3af
commit fd05d6f504
81 changed files with 535 additions and 535 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
pc/jsep_transport_controller_unittest.cc
View File

@ -349,7 +349,7 @@ class JsepTransportControllerTest : public JsepTransportController::Observer,
int gathering_state_signal_count_ = 0;
int candidates_signal_count_ = 0;
// `network_thread_` should be destroyed after `transport_controller_`
// |network_thread_| should be destroyed after |transport_controller_|
std::unique_ptr<rtc::Thread> network_thread_;
std::unique_ptr<FakeIceTransportFactory> fake_ice_transport_factory_;
std::unique_ptr<FakeDtlsTransportFactory> fake_dtls_transport_factory_;
@ -905,14 +905,14 @@ TEST_F(JsepTransportControllerTest, IceSignalingOccursOnNetworkThread) {
}
// Test that if the TransportController was created with the
// `redetermine_role_on_ice_restart` parameter set to false, the role is *not*
// |redetermine_role_on_ice_restart| parameter set to false, the role is *not*
// redetermined on an ICE restart.
TEST_F(JsepTransportControllerTest, IceRoleNotRedetermined) {
JsepTransportController::Config config;
config.redetermine_role_on_ice_restart = false;
CreateJsepTransportController(config);
// Let the `transport_controller_` be the controlled side initially.
// Let the |transport_controller_| be the controlled side initially.
auto remote_offer = std::make_unique<cricket::SessionDescription>();
AddAudioSection(remote_offer.get(), kAudioMid1, kIceUfrag1, kIcePwd1,
cricket::ICEMODE_FULL, cricket::CONNECTIONROLE_ACTPASS,
@ -1996,7 +1996,7 @@ TEST_F(JsepTransportControllerTest, BundleSubsetOfMediaSections) {
->SetRemoteDescription(SdpType::kAnswer, remote_answer.get())
.ok());
// Verifiy that only `kAudio1` and `kVideo1` are bundled.
// Verifiy that only |kAudio1| and |kVideo1| are bundled.
auto transport1 = transport_controller_->GetRtpTransport(kAudioMid1);
auto transport2 = transport_controller_->GetRtpTransport(kAudioMid2);
auto transport3 = transport_controller_->GetRtpTransport(kVideoMid1);
@ -2170,7 +2170,7 @@ TEST_F(JsepTransportControllerTest, ChangeBundledMidNotSupported) {
EXPECT_TRUE(bundle_group.RemoveContentName(kAudioMid1));
bundle_group.AddContentName(kAudioMid1);
// The answerer uses the new bundle group and now the bundle mid is changed to
// `kVideo1`.
// |kVideo1|.
remote_answer->RemoveGroupByName(cricket::GROUP_TYPE_BUNDLE);
remote_answer->AddGroup(bundle_group);
EXPECT_TRUE(transport_controller_