zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Adopt absl::string_view in rtc_base/string_encode.*

Browse Source 
Bug: webrtc:13579
Change-Id: If52108d151a12bde0e8d552ce7940948c08cef3a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256812
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Ali Tofigh <alito@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36424}
This commit is contained in:
Ali Tofigh
2022-03-31 10:36:48 +02:00
committed by WebRTC LUCI CQ
parent f2599a7f43
commit fd6a4d6e2a
17 changed files with 125 additions and 114 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
modules/audio_coding/acm2/audio_coding_module_unittest.cc
View File

@ -1114,8 +1114,7 @@ class AcmSenderBitExactnessOldApi : public ::testing::Test,
// Extract and verify the payload checksum.
rtc::Buffer checksum_result(payload_checksum_->Size());
payload_checksum_->Finish(checksum_result.data(), checksum_result.size());
checksum_string =
rtc::hex_encode(checksum_result.data<char>(), checksum_result.size());
checksum_string = rtc::hex_encode(checksum_result);
ExpectChecksumEq(payload_checksum_ref, checksum_string);
// Verify number of packets produced.

9
modules/audio_coding/neteq/test/result_sink.cc
View File

@ -10,8 +10,9 @@
#include "modules/audio_coding/neteq/test/result_sink.h"
#include <vector>
#include <string>
#include "absl/strings/string_view.h"
#include "rtc_base/ignore_wundef.h"
#include "rtc_base/message_digest.h"
#include "rtc_base/string_encode.h"
@ -91,10 +92,10 @@ void ResultSink::AddResult(const NetEqNetworkStatistics& stats_raw) {
}
void ResultSink::VerifyChecksum(const std::string& checksum) {
std::vector<char> buffer;
std::string buffer;
buffer.resize(digest_->Size());
digest_->Finish(&buffer[0], buffer.size());
const std::string result = rtc::hex_encode(&buffer[0], digest_->Size());
digest_->Finish(buffer.data(), buffer.size());
const std::string result = rtc::hex_encode(buffer);
if (checksum.size() == result.size()) {
EXPECT_EQ(checksum, result);
} else {

3
modules/audio_coding/neteq/tools/audio_checksum.h
View File

@ -50,8 +50,7 @@ class AudioChecksum : public AudioSink {
finished_ = true;
checksum_->Finish(checksum_result_.data(), checksum_result_.size());
}
return rtc::hex_encode(checksum_result_.data<char>(),
checksum_result_.size());
return rtc::hex_encode(checksum_result_);
}
private: