Add EncodedImageCallback::OnEncodedImage without RTPFragmentationHeader

RTPFragmentationHeader is no longer used by any webrtc code.

Bug: webrtc:6471
Change-Id: I1362d58465c550f5c8e0a5b292dc0abcd6251431
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180120
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31833}
This commit is contained in:
Danil Chapovalov
2020-07-23 11:28:50 +02:00
committed by Commit Bot
parent f29fdfc5cb
commit fdd41ecf6b
3 changed files with 27 additions and 4 deletions

View File

@ -18,6 +18,19 @@
namespace webrtc {
EncodedImageCallback::Result EncodedImageCallback::OnEncodedImage(
const EncodedImage& encoded_image,
const CodecSpecificInfo* codec_specific_info,
const RTPFragmentationHeader* /*fragmentation*/) {
return OnEncodedImage(encoded_image, codec_specific_info);
}
EncodedImageCallback::Result EncodedImageCallback::OnEncodedImage(
const EncodedImage& encoded_image,
const CodecSpecificInfo* codec_specific_info) {
return OnEncodedImage(encoded_image, codec_specific_info, nullptr);
}
// TODO(mflodman): Add default complexity for VP9 and VP9.
VideoCodecVP8 VideoEncoder::GetDefaultVp8Settings() {
VideoCodecVP8 vp8_settings;

View File

@ -73,10 +73,16 @@ class EncodedImageCallback {
};
// Callback function which is called when an image has been encoded.
virtual Result OnEncodedImage(
const EncodedImage& encoded_image,
const CodecSpecificInfo* codec_specific_info,
const RTPFragmentationHeader* fragmentation) = 0;
// Deprecated, use OnEncodedImage below instead, see bugs.webrtc.org/6471
virtual Result OnEncodedImage(const EncodedImage& encoded_image,
const CodecSpecificInfo* codec_specific_info,
const RTPFragmentationHeader* fragmentation);
// Callback function which is called when an image has been encoded.
// TODO(bugs.webrtc.org/6471): Make pure virtual
// when OnEncodedImage above is deleted.
virtual Result OnEncodedImage(const EncodedImage& encoded_image,
const CodecSpecificInfo* codec_specific_info);
virtual void OnDroppedFrame(DropReason reason) {}
};